Open main menu

Topic on Talk:Phabricator/Help

Permission to edit global herald rules

8
Martin Urbanec (talkcontribs)

Why is power to edit global herald rules assigned to #repository admins? Seems pretty random to me.

AKlapper (WMF) (talkcontribs)

"Can manage global rules" is set to "Phabricator admins" and to members of #Repository-Admins and #acl*phabricator.

Martin Urbanec (talkcontribs)

The question is why, through. Why should be repo admins able to do that?

Jdforrester (WMF) (talkcontribs)

It's used quite often when adjusting project hierarchies (and updating related Herald rules).

Martin Urbanec (talkcontribs)

Tbh, I feel that's...not so nice. What if editing global herald rules is an useful thing for me, but #acl*phabricator seems huge for that thing, and #repository-admins is about something else, but kinda an overkill too. What should one request to be able to do this? Or should people not request solely this ability for a reason I don't see?

Martin Urbanec (talkcontribs)

A special group would make sense IMO. Thanks for explaining why it works that way, but I still think it's mixing two things, somehow.

Also, what should I tag if I want a global herald rule to be edited? #repository-admins seems like a total nonsense at the first glance, but the only tag I know that has at least some relationship to the issue. I did so at https://phabricator.wikimedia.org/T230831, and it was removed by Andre "because it has nothing to do with repos". Agreed, but I don't see a good way then.

Jdforrester (WMF) (talkcontribs)

Herald is exceptionally slow, heavy code and already over-used. I'm not sure creating new avenues encouraging further use of this tool (which slows down the whole of Phabricator for every other user) is a great idea.

Martin Urbanec (talkcontribs)

Agreed. On the other hand, I don't think keeping repository admins the "only" point of contact is a good idea. I agree herald is quite used (probably over-used), and I'm aware of the slowness issue. The first thing makes it even more likely to have "I need this herald rule to be edited" type of requests. How should one handle that should be...documentated, probably.

The avenue doesn't need to encouraging further uses of this tool. It can even discouradge from it, explaining why herald is not a good idea probably and should be used only when no other good thing exists (or seems to exist). I can ask one of the repo admins I know, but wouldn't the preferred way to request such stuff be create a ticket? My only concern is how to tag it, that's all. Tagging with repository-admins seems reasonable given how permissions are configured, but is strange at the first, second and probably also third glance. I hope you understand it.

PS: How would you recommend to handle team and code type of connections? For instance, the Growth team manages the GrowthExtension, but tags to tag both with growth-team and growthexperiments exist, to have way to query for tasks "connected with growthexperiments extension" as well as "tasks worked on, or watched by, the growth team". It's natural growth team needs a good way to tag things tagged with growthexperiments also with growth-team. However, I'm not aware of any option besides global herald rule. You may know better, through.