Topic on Extension talk:VEForAll/Flow

What commit # to checkout for MW 1.34 combability?

15
Revansx (talkcontribs)

The "Compatibility Policy" for VEForAll is "master", but sadly that crashes my MW 1.34 wiki.

So I tried the REL1_34 branch of VEForAll which kinda works (basic editing is ok) but using anything on the toolbars features cause it crash.

I can't update to 1.35 yet. Does anyone know a branch, commit, or fork of VEForAll that works with 1.34?

  • MediaWiki: 1.34.4 (e34e7f2) 13:19, 24 September 2020
  • VisualEditor: 0.1.1 (74116a7) 18:02, 23 December 201
  • VEForAll: 0.1 (3032e34) 14:14, 3 October 2019
Yaron Koren (talkcontribs)

I think the latest code should work fine with MW 1.34.

Revansx (talkcontribs)

Here's the error I get when I use VEForAll master:

Fatal error: Uncaught ExtensionDependencyError: VEForAll is not compatible with the current MediaWiki core (version 1.34.4), it requires: >= 1.35.0. in /opt/htdocs/mediawiki/includes/registration/ExtensionRegistry.php:334 Stack trace: 
#0 /opt/htdocs/mediawiki/includes/registration/ExtensionRegistry.php(186): ExtensionRegistry->readFromQueue(Array) 
#1 /opt/htdocs/mediawiki/includes/Setup.php(143): ExtensionRegistry->loadFromQueue() 
#2 /opt/htdocs/mediawiki/includes/WebStart.php(81): require_once('/opt/htdocs/med...') 
#3 /opt/htdocs/mediawiki/index.php(41): require('/opt/htdocs/med...') 
#4 {main} thrown in /opt/htdocs/mediawiki/includes/registration/ExtensionRegistry.php on line 334
Revansx (talkcontribs)
Revansx (talkcontribs)

I just changed line 12 of extension.json from

"MediaWiki": ">= 1.35.0",

to

"MediaWiki": ">= 1.34.0",

and it seems to work better on MW 1.34.4 than the REL1_34 branch does. Does that make sense?

Yaron Koren (talkcontribs)

Oh, wow, I didn't notice that the required MediaWiki version for VEForAll was bumped up about six months ago. I just reverted that change, so now the requirement is back to 1.29. I'm glad to hear that it still works with earlier versions.

Revansx (talkcontribs)

Thanks. I fetched that latest version and verified that extension.json had the MW was requirement at >1.29.0.

  • Good news - All the VE tools work including tables
  • Bad news - The Save button no longer works.

Cindy mentioned that she thought saw a change recently that specifically mentioned 1.35 that might have driven the bump in MW version required. Does that ring any bells?

Yaron Koren (talkcontribs)

No. Do you see any error messages in the JavaScript console?

Revansx (talkcontribs)

I do not.

Revansx (talkcontribs)
Revansx (talkcontribs)

Here's what it is doing:

In VE mode:

  • If the text field is empty, then the form saves
  • If I add text to a VEForALll textarea field, then the form no longer saves

In wikitext node:

  • If I add text to a textaraea field, the form will save as if should

When I go to "re-edit" a form that has text saved from the wikitext mode:

  • The text shows in the textarea fields, but there are not editable
  • When I save the form, the existing text is lost.

There are no JS errors in any failure mode

It seems to be an API issue.

Cavila (talkcontribs)

Same here (MW 1.35). I haven't tested things extensively, but in the case of multiple-instance templates I have the same problems you described. Which is a pity because VEforAll is the only extension which at least in theory, supports having WYSIWYG editors in multiple instances.

Still no fixes I'm afraid.

Revansx (talkcontribs)

It should be an easy fix for those maintaining the skin.. We just have to do our part and report it! :-)

Yaron Koren (talkcontribs)

@Cavila - what versions of VEForAll and Page Forms are you running?

Cavila (talkcontribs)

I've tested VEForAll 0.4 with PF 5.3.2 as well as with an earlier version (PF 4.7).

  • For pre-existing instances, the textarea with editor=visualeditor shows the 'raw' source text. It looks slightly greyed out and is not editable.
  • I can add new instances with VE loading just fine.
  • Unless I click the bottom right toggle. If it works (which it doesn't necessarily), there seems no way to toggle back to VE.
  • There are some warnings but no error messages in the console such as Empty string passed to getElementById() and No name: {"type":"menu","include":{"group":"format"},"promote":["paragraph"],"demote":["preformatted","blockquote"]}
  • After I hit save, the content in textareas with VE is gone.
Reply to "What commit # to checkout for MW 1.34 combability?"