Talk:OOjs

Git link broken

Git links seem to be incorrect Jdlrobson (talk) 17:53, 15 August 2014 (UTC)

Fixed; thanks! Jdforrester (WMF) (talk) 14:17, 16 August 2014 (UTC)

oojs.jquery.min.js removal in v6.0

@Jdforrester (WMF): Hi there, our prototype Firefox add-on project was relying on npm oojs package and its oojs.jquery.min.js. Upgrading my dependency to oojs 6.0.0 (diff) by Timo Tijhof removes this file, as declared. Is there a place with indications on how I should proceed forward to fix my application's code and stop relying on the now defunct oojs.jquery ? Sorry for the question, I'm a junior js developer doing his best. Yug (talk) 09:35, 24 July 2022 (UTC)

Also, on https://www.npmjs.com/package/oojs, you repository link https://gerrit.wikimedia.org/r/oojs/core is broken. Yug (talk) 09:35, 24 July 2022 (UTC)

Yes, sadly the human-readable repo link is https://gerrit.wikimedia.org/g/oojs/core but the git-clonable one is https://gerrit.wikimedia.org/r/oojs/core; the difference is unhelpful! I've pushed a patch to have it point to the human-browsable link instead. Jdforrester (WMF) (talk) 13:36, 25 July 2022 (UTC)

@Yug Hey there. I'm sorry this broke your project; it shouldn't have done so. We only removed the secondary build that re-used bits of jQuery; if your project was relying on us to provide jQuery to other tools, you'll now need to add a direct dependency on it instead (by e.g. adding "jquery": "3.5.1", to your package.json's dependencies block). Jdforrester (WMF) (talk) 13:33, 25 July 2022 (UTC)

Oh, strange. We have both jquery.min.js(3.6) and oojs.jquery.min.js, but somehow removing the later breaks our code despite the remaining jquery 3.6.

I'm not sure if I understand well, but I believe your oojs.jquery formerly also bundled other small codes aside of jquery. Maybe one of those is the missing brick in my project. Yug (talk) 13:54, 25 July 2022 (UTC)

Both of those are copied silently from node_modules because you expect them to be there, but in your package.json file you don't directly use them.

The only change between v5.0.0 and v6.0.0 was the dropping of the jQuery dependency; we never bundled anything else. Jdforrester (WMF) (talk) 14:19, 25 July 2022 (UTC)