MarkAHershberger

Previous discussion was archived at User talk:MarkAHershberger/Archive 1 on 2016-08-16.

You wrote:

"Someone who runs one of these problematic wikis offered a patch for an extension I wrote. I would like to accept their solicitation of help even though I do not want to endorse their beliefs. I could redact anything that ties the contribution to their odious wiki. But this policy seems like it would prevent me from accepting their patch."

We have published a number of extensions. If complete extensions are accepted here, why accepting a patch shouldn't be allowed?

See https://phabricator.wikimedia.org/T323956 for a discussion of the issues.

This deals with indexing for MediaWiki code search. I can not see anything about accepting entire extensions or accepting a patch. No "remove of code" or something similar. Nothing at all.

"Wikipedia:Be bold" - This is also part of the project. ;-)

New Version 0.5.4 published in our GitHub repository. Mostly refactoring.

New in our GitHub repository!

I would argue that "hitcounter-exempt" should be a custom setting rather than a permission.--WikiForMen (talk) 16:25, 28 October 2023 (UTC)

I add some code improvements today.--WikiForMen (talk) 12:05, 29 October 2023 (UTC)

I found an issue in composer.json. "suppport" is misspelled.

HitCounters Version 0.5.3 published.

Version 0.5.1 adds Code Review:

1. Changed "configuration schema", replaced manifest version 1 with version 2.
2. Replaced static functions with implementing interfaces in class “Hooks”.

--WikiForMen (talk) 23:41, 27 October 2023 (UTC)

Was this intended to be a statement or a question?

Are you forking HitCounters? since the public repo doesn't seem to have such a version

Edit: Found the fork, Why is this not just getting contributed to the main gerrit repo so everyone can benefit from the changes?

gerrit repo is far to complicated. Now I have problems to get into GitHub. Its all too time consuming...--WikiForMen (talk) 11:50, 28 October 2023 (UTC)

I think it is just him letting me know what he has been doing. His work has encouraged me to see how it could be improved.

At the moment I can not even access to my GitHub account because of the recent changes on GitHub.

[Edit] Problem solved, changes are found in our GitHub repository!

I guess it rises HitCounters to the actual standards. It is working since v1.35.0.--WikiForMen (talk) 11:57, 28 October 2023 (UTC)

Version 0.5.0 adds custom settings.--WikiForMen (talk) 16:18, 9 October 2023 (UTC)

	দয়ালু মনোভাবের পদক
	Random act of kindness Barnstar for your detailed answer

Hi Mark, not sure if this extension is still maintained. Anyhow the source is no longer available. I guess it will be best to either update or archive the extension. Thanks and cheers

Thanks for pointing this out. I had moved it a while back. I'll update the link.

Thank you! I updated the page a bit further. Looks cool now.

Hello,

I did a Code review - Refactoring to Extension HitCounters:

https://github.com/WikiMANNia/Mediawiki-Extension-HitCounters/releases/tag/REL1_39-v0.4.0

HitCounters/includes/HitCounters.body.php

join_conds part in getQueryInfo()

Table name should be alias name.

'join_conds' => [
//'page' => [   ここが間違い。エイリアス名使わないとだめ 'p' => [

re throw

'join_conds' => [

//'page' => [ NG

  'p' => [　　　 //OK.

118.10.63.36 is SuperYo-net.

Create acount.

why did you get rid of the fnaf, for literally one thing just a question@MarkAHershberger

I do not know what you are talking about.