Topic on Talk:MediaWiki Language Extension Bundle

Universal Language Selector Git master error

2
Brunogabuzomeu (talkcontribs)

Having installed MLEB 2021.12 (MediaWiki 1.35.5), when I upgrade Universal Language Selector to Git master because of security issue T293749, CVE-2021-46149 (//gerrit.wikimedia.org/r/q/Ide32704cca578b9aecbce34bdcc0ac25c2a09a4d), I get this error:


Original exception: /index.php?title=Special:Version Error from line 236 of /mediawiki/extensions/UniversalLanguageSelector/includes/Hooks.php: Using $this when not in object context

Backtrace:

#0 /mediawiki/includes/HookContainer/HookContainer.php(329): UniversalLanguageSelector\Hooks::onPersonalUrls()

#1 /mediawiki/includes/HookContainer/HookContainer.php(132): MediaWiki\HookContainer\HookContainer->callLegacyHook()

#2 /mediawiki/includes/HookContainer/HookRunner.php(3084): MediaWiki\HookContainer\HookContainer->run()

#3 /mediawiki/includes/skins/SkinTemplate.php(656): MediaWiki\HookContainer\HookRunner->onPersonalUrls()

#4 /mediawiki/includes/skins/SkinTemplate.php(392): SkinTemplate->buildPersonalUrls()

#5 /mediawiki/includes/skins/SkinTemplate.php(127): SkinTemplate->prepareQuickTemplate()

#6 /mediawiki/includes/skins/SkinTemplate.php(144): SkinTemplate->generateHTML()

#7 /mediawiki/includes/OutputPage.php(2622): SkinTemplate->outputPage()

#8 /mediawiki/includes/MediaWiki.php(952): OutputPage->output()

#9 /mediawiki/includes/MediaWiki.php(965): MediaWiki->{closure}()

#10 /mediawiki/includes/MediaWiki.php(548): MediaWiki->main()

#11 /mediawiki/index.php(53): MediaWiki->run()

#12 /mediawiki/index.php(46): wfIndexMain()

#13 {main}

Nikerabbit (talkcontribs)

Master branch does not support 1.35. Please use the latest version of REL1_35 branch or the 2021.12 MLEB tag, both of which include the fix for the vulnerability.

This issue would affect future MLEB release, though, so I created a task to address it before a release: https://phabricator.wikimedia.org/T299305