Topic on Talk:Gerrit/Commit message guidelines/Archive 2

New gerrit UI does not fit 100 characters in the commit message box

5
DMaza (WMF) (talkcontribs)

As part of the guidelines for the body we suggest keeping lines with a max of 100 characters. That doesn't work anymore with the new gerrit UI. I suggest we change it to 65-70 max (unless we can change the width of that box)

MusikAnimal (WMF) (talkcontribs)

The industry standard seems to be 72 characters for the body. Perhaps Gerrit is expecting that.

Jdforrester (WMF) (talkcontribs)

[Posting here because @TK-999 boldly changed the guidance from 100 to 72, and I reverted.]

I slightly disagree; the length of 100 chars works well enough. Happy to go with the flow if there's consensus, of course.

Also, given we're migrating off gerrit, I think we shouldn't worry too much about current UX issues there, assuming this guidance will outlast it.

DMaza (WMF) (talkcontribs)

I agree, no need to discuss or change this now.

Lucas Werkmeister (WMDE) (talkcontribs)

I’ve slightly updated the text (mainly because I disliked the guidance to manually wrap the message), and added a mention of the customary 72 limit, while leaving 100 as the maximum. permalink