Topic on Extension talk:OpenID Connect

Evolution of OpenId Connect Extension

5
Summary by Cindy.cicalese

Feature requested in OpenID Connect library.

BrunoPenso (talkcontribs)

Hi Team,


Since the problem reported on this page with the title "oidc_subject is null" I made a enhacement on the extension, but I couldn't find the github for the MediaWiki extension of OpenIDConnect.


The customization on the jumbojett (https://github.com/jumbojett/OpenID-Connect-PHP) is ready.


Can you help?

BrunoPenso (talkcontribs)
Cindy.cicalese (talkcontribs)

The OpenID Connect MediaWiki extension is maintained in Gerrit, not github. However, the change that you refer to needs to be made in the OpenID Connect PHP library that you link to above (https://github.com/jumbojett/OpenID-Connect-PHP), not in the OpenID Connect MediaWiki extension. The library is a separate project that is a dependency of the extension. Once the change is made in the library, the extension will be able to take advantage of it by updating the library version in the extension's composer.json file (https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/OpenIDConnect/+/master/composer.json#18).

BrunoPenso (talkcontribs)

Hi Cindy, the customization were made on the Mediawiki and php extension. How should I proceed?

Cindy.cicalese (talkcontribs)

I suggest submitting a pull request to go with the issue you submitted on github (https://github.com/jumbojett/OpenID-Connect-PHP/issues/189). This pull request should only include the changes to the requestUserInfo() function of OpenIDConnectClient.php. I see that you submitted another pull request that includes MediaWiki code, which should not be included (https://github.com/jumbojett/OpenID-Connect-PHP/pull/187/files). It should only include changes to OpenIDConnectClient.php. The MediaWiki code should not have to change.