Topic on Extension talk:WikiEditor

Will be fixed in MediaWiki 1.29.1.

When clicking on "Embedded file", the "insert file" window pops up. But when I click on "upload" there, the window closes and nothing happens. This problem occurs in my 1.29.0 version, in a separate 1.28.2 installation (on the same server), the upload works fine.

In the browser console, I get the following error (in the 1.28.2 version, I don't get errors):

:Uncaught Error: Windows must have a `name` static property defined.

load.php?debug=false&lang=en&modules=jquery.accessKeyLabel%2Casync%2CbyteLength%2CbyteLimit%2Ccheck…:537

at OoUiWindowManager.OO.ui.WindowManager.addWindows (load.php?debug=false&lang=en&modules=jquery.accessKeyLabel%2Casync%2CbyteLength%2CbyteLimit%2Ccheck…:537)

    at HTMLDivElement.wikieditor-toolbar-tool-file-upload (load.php?debug=false&lang=en&modules=ext.wikiEditor|ext.wikiEditor.core%2Cdialogs%2Cpreview%2Cpubli…:60)

    at HTMLButtonElement.props.click (load.php?debug=false&lang=en&modules=jquery.ui.button%2Ccore%2Cdialog%2Cdraggable%2Cmouse%2Cpositio…:24)

    at HTMLButtonElement.dispatch (load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=0ax79ee:65)

    at HTMLButtonElement.elemData.handle (load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=0ax79ee:60)

Is this a bug in the new version?

Hi there, good spot.

This was bug T164999 which we fixed a few hours after the cut for MediaWiki 1.29 and didn't notice, sorry!

I've made https://gerrit.wikimedia.org/r/#/c/366262/ as a backport of the fix, and that should be released in MediaWiki 1.29.1. If it's urgent, you should be able to apply it locally.

Sorry for the issue.

Thank you for the quick response! I applied the changes in "mediawiki.Upload.Dialog.js" and now the upload works again.