Topic on Skin talk:BootStrapSkin

Thank you for your effort in creating this nice skin! Will give it a try soon! Cheers

Awesome, nothing beats a great peer review, really appreciate your kind words :)

I really like the design. A lot of website have become indistinguishable because of BootStrap, but this on adds a reputable and clear note to it.

Wrote a lot of code for the skin, default bootstrap.css is around 6k, mine has over 33k, though the vast majority is for the extra colour classes, but also adds effects and quality, e.g. border shading etc. Plus I've removed some of the default bootstrap js and replaced with (what I consider to be) better code. I have nine other css files ready for future releases, all are pretty much the same but each uses a different base colour, the current version ships with bootstrap-blue.css which is what can be seen at the demo site.

Gonna get on with changing the code now :)

Wow, about 5 times as much CSS. You surely did a big job here. Doesn't this degrade performance a bit. Hmm ..., we are probably talking about miliseconds and the CSS will probably not be stacked or so. I guess it also depends on which classes on is using on the acutal wiki page.

The page partially renders pretty quickly at around 1.25 seconds and The bootstrap-blue file loads in 138 ms.

The biggest resource hogger (as you probably suspected) is the Javascripts, theres a lot of stuff in there, which is what allows for the effects and extra functionality, takes around 4-5 seconds to completely load! Though of course this all goes on in the background, a normal visitor wouldn't notice I don't think becuase the page is viewable at the 1.25 second mark.

Of course after the first visit cache helps.

Indeed, interesting. I have to see it in action. No way around it. Perhaps I can provided numbers from my machine - just for comparison.

That would be very helpful :)

Thank you, Lee Miller, for such a wonderful job! It might come as a culture shock to many MW users who've grown accustomed to ugly layouts, so please bear with us while we're recovering. I will try this out soon (it doesn't work for me yet because the collapsed menus are not expanding, but it might just as well be me).

Hi Cavila,

many thank really appreciate your kind words, they mean a lot :)

Which version are you using, I tested 0.0.40 on a couple of browsers and on xampp and there weren't any issues.

0.0.39 does not work (and suffers from the non expanding menu issue), when I updated from 38 - 39 there was a Javascript conflict (lightbox, magnific-popup and Gritter), which I've now removed at the expense of the Gritter notification and form functionality, all of which were to be included in the July update.

A quick fix to solve the drop down issue is to remove (or comment out i.e. # lines 48 and 50 from bootstrapskin.php;

'bootstrap/bootstrap/js/holder.js',
'bootstrap/bootstrap/js/magnific/jquery.magnific-popup.min.js',
'bootstrap/bootstrap/js/lightbox/lightbox.js',

Please let me know if this solves it for you, it worked for me :)

Many thanks again, Lee :)

Is a bit of nightmare, I don't usually suffer from js conflicts, perhaps more knowledge of Mediawiki would be beneficial, would happily appreciate any support from any developers with this type of experience?

All done, have updated version 0.0.40 shouldn't be any problems now (touch wood!) :)

If you have the time would really appreicate any feedback and reporting of problems.