Extension talk:CategoryWatch/Archive 2

--> Archived talk

When trying to unapprove a version which seems to be watched through Category Watch, I get this error :

[ZN98yvBbaMvLEWfjFhArygAAAAs] /wiki/index.php?title=RDS_-_Remote_Desktop_Services&action=unapprove Error: Call to undefined method WikiPage::getRevision()

Backtrace:

from /app/htdocs/wiki/extensions/CategoryWatch/src/Hook.php(238)

1. 0 /app/htdocs/wiki/includes/HookContainer/HookContainer.php(338): CategoryWatch\Hook::onCategoryAfterPageRemoved()
2. 1 /app/htdocs/wiki/includes/HookContainer/HookContainer.php(137): MediaWiki\HookContainer\HookContainer->callLegacyHook()
3. 2 /app/htdocs/wiki/includes/HookContainer/HookRunner.php(1067): MediaWiki\HookContainer\HookContainer->run()
4. 3 /app/htdocs/wiki/includes/page/WikiPage.php(3099): MediaWiki\HookContainer\HookRunner->onCategoryAfterPageRemoved()
5. 4 /app/htdocs/wiki/includes/deferred/LinksUpdate/CategoryLinksTable.php(311): WikiPage->updateCategoryCounts()
6. 5 /app/htdocs/wiki/includes/deferred/LinksUpdate/CategoryLinksTable.php(277): MediaWiki\Deferred\LinksUpdate\CategoryLinksTable->updateCategoryCounts()
7. 6 /app/htdocs/wiki/includes/deferred/LinksUpdate/LinksTable.php(398): MediaWiki\Deferred\LinksUpdate\CategoryLinksTable->finishUpdate()
8. 7 /app/htdocs/wiki/includes/deferred/LinksUpdate/LinksUpdate.php(294): MediaWiki\Deferred\LinksUpdate\LinksTable->update()
9. 8 /app/htdocs/wiki/includes/deferred/LinksUpdate/LinksUpdate.php(254): MediaWiki\Deferred\LinksUpdate\LinksUpdate->doIncrementalUpdate()
10. 9 /app/htdocs/wiki/extensions/ApprovedRevs/includes/ApprovedRevs.php(593): MediaWiki\Deferred\LinksUpdate\LinksUpdate->doUpdate()
11. 10 /app/htdocs/wiki/extensions/ApprovedRevs/includes/ARUnapproveAction.php(31): ApprovedRevs::unsetApproval()
12. 11 /app/htdocs/wiki/includes/MediaWiki.php(542): ARUnapproveAction->show()
13. 12 /app/htdocs/wiki/includes/MediaWiki.php(322): MediaWiki->performAction()
14. 13 /app/htdocs/wiki/includes/MediaWiki.php(904): MediaWiki->performRequest()
15. 14 /app/htdocs/wiki/includes/MediaWiki.php(562): MediaWiki->main()
16. 15 /app/htdocs/wiki/index.php(50): MediaWiki->run()
17. 16 /app/htdocs/wiki/index.php(46): wfIndexMain()
18. 17 {main}

Mediawiki 1.39.4 with latest version of both extensions.

MediaWiki	1.31.1
PHP	7.1.8 (apache2handler)
Echo release 1.31
CategoryWatch	2.0, 2017-09-19 (542f9a1) 16:24, 17 April 2018
LocalSettings:
wfLoadExtension( 'Echo' );
#$wgRCWatchCategoryMembership=true;
wfLoadExtension( 'CategoryWatch' );
$wgCategoryWatchNotifyEditor = true;

When I move a page into or out of a category I get nothing.

This extension from the official repo has some bugs. A fix for your issue can be found here: https://github.com/gesinn-it-pub/mediawiki-extensions-CategoryWatch/commit/5094ed0b208c6704b9644af5f6dd9b6666ce2d54

Either patch the official repo or use https://github.com/gesinn-it-pub/mediawiki-extensions-CategoryWatch

First off, I want to preface this by saying that this extension adds a REALLY useful functionality, which should really be part of MW core. Though dealing with possible risks and consequences may be why it's not.

Say you have a category that's being watched by many people, as soon as someone adds a new page to it, those watching the category will receive a notification. This is the expected behaviour and this extension works great.

However, since anyone with edit right on any given page is able to add that page to any category they want, could this extension lead to abuse/false positives with email notifications? Even on a wiki where only authorised users can edit a particular page in a particular namespace.

I don't think it's possible to restrict the ability to add a page to a category, which would go against a core functionality of MediaWiki. But would it be possible to check the name of the person responsible for the edit (e.g. {{REVISIONUSER}}) that added a particular page to the category against a tag on the category page which defines those people whose edits--which add the page to the category--will trigger the notification?

I'm reluctant to enable this extension even though it adds a really really great functionality that could be the lynch pin in getting people on board the wiki train at my company. Does any one have any suggestion on how to control the risk associated with this?

We use this extension extensively for workflow management, especially the 'Automatically watched by User' feature. While you could probably hack it to do what you're after, we haven't experience ANY kind of behavior like you're describing. Though, our wiki is internal and does not allow anonymous edits.

I think watching a category was added to the core somewhere around 1.25. Though have to add a line to your local settings to activate it. Manual:CategoryMembershipChanges.