Wikimedia Release Engineering Team/Checkin archive/2023-09-20
Β
π Wins
edit- https://www.mediawiki.org/wiki/Wikimedia_Release_Engineering_Team/Monthly_notable_accomplishments
- Sep '23 edition
- Image published for Blubber that is native LLB, no dockerfile anymore
- implications
- dockerfile is unnecessary since no one sees the dockerfileβwe can customize each llb instruction and what it displays to the users: a name that corresponds to the blubber.yaml config
- now we have the ability to create our own instructions
- dockerfile2llb gone! No more external helper images that haven't been maintained just to copy files aroundβno more cross-platform compatibility/emulation issues
- llb gets new stuff firstβex: diffop/mergeop https://www.docker.com/blog/mergediff-building-dags-more-efficiently-and-elegantly/
- implications
- Phorge working on the scap3β deployment environment
- Landed 3 upstream phorge patches, 1 is one we've had for years the blocks some tasks rendering (T284397)
- Patch for T&S could outputs the MediaWiki SUL account along with the phab username (T344303)
- Wrote a plugin for tox to keep supporting [tox:jenkins] CI config with tox v4 https://gerrit.wikimedia.org/g/integration/tox-jenkins-overrideΒ unblocking part of the migration from tox v3.
- Moved Civi CRM CI from Stretch to Bullseye and to php 7.4 (aligning with prod). Paired with Ejegg from FR-tech.
- Ahmon refactoring GitLab nodepools, buildkitd persistent volume,Β and containerd debugging
- Dan deep debugging of source code for containerd
- GerritLab uses the git credential helper
- Trusted runners now not running untrusted jobs
- Authentication working in phorge dev environment
- Phabricator housekeeping for open tickets assigned for more than two years
- Phabricator logstash dashboard with filters
OKR update
editLast week
editThe six questions I answer week-by-week about our work. This is pretty much all CTPO/VP/Director-types see for what we're doing. If there are specific things to call out here, let's do.
On track
Progress update on the hypothesis for the week T343035 β Sync ldap/ops users to group on GitLab β All members of SRE are now owners of the repos/sre subgroup on GitLab T346084 β Consulting with data engineering on memory-optimized runners on GitLab T346090 β Debian 12 support for python images in our image building tool T344747 β Mathoid migrated to GitLab Any new metrics related to the hypothesis Repositories on Gerrit decreased (2019 last week β 2012 this week) Any emerging blockers or risks Upcoming work to scope stacked testing will give us a better understanding of the risks of MediaWiki migration Any unresolved dependencies - do you depend on another team that hasnβt already given you what you need? Are you on the hook to give another team something you arenβt able to give right now? No Have there been any new learnings from the hypothesis? No Are you working on anything else outside of this hypothesis? If so, what? MediaWiki 1.41.0-wmf.26 298 Patches βββββ in 69 repos by 75 authors 0 Rollbacks βββββ 0 Days of delay βββββ 3 Blockers βββββ T346266 establishing a routine Phab deploy window with serviceops collab
This week
editProgress update on the hypothesis for the week
- Β
Any new metrics related to the hypothesis
- we should report the number of repos in gitlab too
Any emerging blockers or risks
- Β
Any unresolved dependencies - do you depend on another team that hasnβt already given you what you need?
- Β
Are you on the hook to give another team something you arenβt able to give right now?
- Β
Have there been any new learnings from the hypothesis?
- Β
Are you working on anything else outside of this hypothesis? If so, what?
- Β
π» Open source/Upstream contributions
edit- https://github.com/yaoyuannnn/gerritlab/pulls?q=is%3Apr+is%3Aclosed
- https://github.com/tox-dev/tox/issues/3115
- https://github.com/moby/buildkit/pull/4264
- https://gitlab.com/gitlab-org/omnibus-gitlab/-/merge_requests/7101 (we'll see)
πΆ Let's keep these empty
editCode review
editGerrit Access requests
editPrivate repo requests
edithttps://phabricator.wikimedia.org/search/query/E7t2_WXX01bB/#R
Gerrit repo requests
editGitLab Access requests
edit- Account Approval
- Accounts and auth
- GitLab access requests
- Look up username in LDAP ( https://ldap.toolforge.org/ )
- Look for contributions on Gerrit or Phab
High priority tasks
edit- UBN! + High: https://phabricator.wikimedia.org/maniphest/query/PkxR1BXrbbU4/#R
- Can we have this in project defaults? Protected branch: main; protected tags: *
- New in inbox: https://phabricator.wikimedia.org/maniphest/query/7vRDrcVnt8OI/#R
π Vacations/Important dates
edit- https://office.wikimedia.org/wiki/HR_Corner/Holiday_List#2023
- https://wikitech.wikimedia.org/wiki/Deployments/Yearly_calendar
- https://www.mediawiki.org/wiki/Wikimedia_Release_Engineering_Team/Time_off
September 2023
edit- 04 Sep: Labor day (US Staff with reqs)
- 08 Sep: Tyler
- 15, 18 Sep: Tyler
- 26 Augβ05 Sep: Brennen (π₯)
- 13 Wedsβ17 Sun: Brennen β KS (approximate)
- 29Fri Sep (moving state holiday from Thu28): Andre
- a few days after December offsite: Andre
October 2023
edit- 2-16 Oct: Jaime
Nov 2023
edit- Β
Dec 2023
edit- Β
Future
edit- 15Jan - 15Mar: Andre
π₯π Train
edit- https://tools.wmflabs.org/versions/
- https://train-blockers.toolforge.org/
- https://wikitech.wikimedia.org/wiki/Deployments/Yearly_calendar
- 2 Jan - wmf.17 - Dan + Antoine (Jaime out)
- 9 Jan - wmf.18 - Jeena + Dan (Jaime out)
- 16 Jan - wmf.19 - Jaime + Jeena
- 23 Jan - wmf.20 - Brennen + Jaime
- 30 Jan - wmf.21 - Ahmon + Brennen
- 6 Feb - wmf.22 - Chad + Ahmon
- 13 Feb - wmf.23 β Dan + Chad
- 20 Feb - wmf.24 β Antoine + Dan
- 27 Feb - wmf.25 β Jaime + Antoine
- 6 Mar β wmf.26 β Jeena + Jaime
- 13 Mar β wmf.27 β Brennen + Jeena
- 20 Mar β wmf.1 β Ahmon + Brennen
- 27 Mar β wmf.2 β Chad Dan + Ahmon
- 3 Apr β wmf.3 β Antoine + Dan
- 10 Apr β wmf.4 β Chad + Antoine
- 17 Apr β wmf.5 β Jaime + Chad
- 24 Apr β wmf.6 β Jeena + Jaime
- 1 May β wmf.7 β Brennen + Jeena
- 8 May β wmf.8 β Antoine + Brennen (Ahmon out + Antoine Out 8th)
- 15 May β wmf.9 β Ahmon + Antoine (Dan out + Chad out)
- 22 May β wmf.10 β Chad + Ahmon (Dan out + Jeena out 26th)
- 29 May β wmf.11 β Dan + Chad (Memorial Day 29th)
- 5 Jun β wmf.12 β Jeena + Dan (Brennen out, Jaime out)
- 12 Jun β wmf.13 β Jaime + Jeena
- 19 Jun β wmf.15 β Cancelled for offsite
- 26 Jun β wmf.16 β Brennen + Jaime (Jeena out)
- 3 Jul β wmf.17 β Antoine + Brennen (3rd + 4th holidays)
- 10 Jul β wmf.18 β Dan + Antoine (Ahmon out)
- 17 Jul β wmf.19 β Ahmon+Dan (Brennen out Friday)
- 24 Jul β wmf.20 β Jaime+Ahmon
- 31 Jul β wmf.21 β Ahmon+Jaime (Jeena out, Antoine out) (Ahmon volunteered)
- 7 Aug β wmf. 22 β No train
- 14 Aug - wmf.23 β Ahmon+Jaime (Jeena out, Antoine out)
- 21 Aug - wmf.24 β Dan(brennen out, Jeena out, Antoine out)
- 28 Aug β wmf.25 β Jeena+Dan
- 04 Sep β wmf.26 β Antoine+Jeena
- 11 Sep β wmf.27 β Jaime+Antoine+Andre as lurker!
- 18 Sep β wmf.28 β Brennen+Jaime
- Logspam-watch needs some attention
- Every deploy is rebuilding l10n
- 25 Sep β 1.42.0-wmf.1 β Dan + Brennen
- 2 Oct β 1.42.0-wmf.2 β Jeena + Dan (Jaime Out)
- 9 Oct β 1.42.0-wmf.3 β Antoine + Jeena (Jaime Out)
- 16 Oct β 1.42.0-wmf.4 β Brennen + Antoine
- 23 Oct β 1.42.0-wmf.5 β Ahmon + Brennen
- 30 Oct β 1.42.0-wmf.6 β Dan + Ahmon
Team discussions
editGitLab meeting recap
edit- the most important thing:Β do what we feel we can support, sustain, and help us achieve our/the orgs goals
- Lots of high-level questions, I think we have more shared understanding
- Options I presented (in order):
- All in one place: GitLab CE or Gerrit
- Split: GitLab CE & Gerrit
- Paid option
- What now?
- Design meeting on GitLab CE Merge Gating (biggest item on https://docs.google.com/document/d/1zczuL1S8A4E3zINdJAam5HwxxASaREUaN3ntfAASGok/edit#heading=h.7qtlock9hcb7 )
- Gather and organize MUST/SHOULD/MAY (per https://www.ietf.org/rfc/rfc2119.txt )
- Investigation Spike
- Questions
- SRE needs vs MediaWiki needs?
- Covering Depends-On + Stacking should meet their needs
- Gating
- Couple things get bunched in: dependent pipelines (save time), setting up the tests, atomic function of performing the merge
- SRE needs vs MediaWiki needs?
- Scope: Depends-on, Dependent pipeline, Merge atomicity
- Pre-work: MUST, SHOULD, MAY
- TODO: Meeting w/Ahmon, Dan, Jeena, Cindy
Offsite!
edit- Brainstorming doc coming soon
- Think about: Work activities, Discussion topics (information sharing/collective decision making), Fun activities