Topic on Skin talk:Pivot

First of all, thanks. Love this skin. I have a problem with images, though. Thumbs in articles show without any style.

So, this...

[[File:A.jpg|thumb|alt=B|C]],

just shows an image and captions below without borders, always on the left, and more.

I know I'm missing a setting or something because this problem doesn't happen on pivot.wikiproject.net. Thanks. Example in this page. All those images in a column on the left are thumbs originally spread around the page.

Already posted at the pivot site, and Kghbln mentioned that looks like "classes thumb tnone and thumbinner are no longer applied to thumbs and instead they use the figure and figcaption tags". How do I go about this?

@Jdlrobson: I assume it is probably just a matter of adding some CSS classes to the repo catering to the change. Do you think this may be the solution, and if yes, which CSS do I need to add? Thanks and cheers

@Cojoilustrado thanks for the bug report!

@Kghbln yes it should be a change to assets/stylesheets/pivot.css. You can use the styles in https://github.com/wikimedia/mediawiki/blob/master/resources/src/mediawiki.skinning/content.media-common.less as a reference.

Thanks for the information and pointer! One last question: I am not much of a CSS, LESS, or SAAS expert: Is it just a matter of converting the file to CSS and adding it to the skin? I assume the imported variables are made available via MediaWiki core and do not need to be repeated?

@Kghbln @Jdlrobson Thanks for the information. This is my report. The css you provided doesn't work out of the box. Alignment worked once I removed the comments (my server doesn't like //) but nothing else. Switching alignment to the left renders undesirable formatting. Captions have no line height among other issues. To regain regular formatting, I added my own styling to pivot.css, but that, of course, is bad practice, but just wanted to regain cosmetic adequacy to the site. How do you convert LESS or SAAS to CSS? Is the css you sent me other than CSS? Linting it gave error in almost every line XD

@Kghbln I can fix this (possibly next week). Feel free to ping me again if I forget or create a ticket to remind me.

@Jdlrobson Thanks! I will. Testing hard the skin. I'll let you know if I find something else.

This will be utterly cool! Thanks a bunch!!!

Have you got an example wiki which demonstrates where this issue is occurring? I took a look today but was unable to reproduce the issue. It might be an issue in an older version so it would be useful to understand this more.

If you don't have a wiki if you could click view source and share the HTML of that page, and the MediaWiki version that should be sufficient for me to work this out.

Thanks in advance.

The link to the wiki is this one https://www.venciclopedia.org/index.php?title=Aditus The wiki is on 1.40.x

I think https://gerrit.wikimedia.org/r/c/mediawiki/skins/Pivot/+/995238 should do it. Try it out and let me know.

@Cojoilustrado: Could you please check? Thanks!

@Kghbln: @Jdlrobson: It's alive! Thumbs working right, left and center. Thanks. There's a problem with icons now, though. Icons like "fa fa-navicon fa-lg" don't show. I guessed it might be that I have preload awesome as false, but when I change to true the whole site crashes into this error. Keeping it off for now.

MediaWiki internal error.

Original exception: [ZcVMIKjQxmXUWP1zFpYmpwAAAAE] /index.php?title=Jorge_Aguilar Error: Call to undefined method PivotTemplate::getOutput()
Backtrace:
from /home/lizardkg/venciclopedia.org/wiki/skins/pivot/Pivot.skin.php(35)
#0 /home/lizardkg/venciclopedia.org/wiki/includes/skins/SkinTemplate.php(155): PivotTemplate->execute()
#1 /home/lizardkg/venciclopedia.org/wiki/includes/skins/SkinTemplate.php(181): SkinTemplate->generateHTML()
#2 /home/lizardkg/venciclopedia.org/wiki/includes/OutputPage.php(2899): SkinTemplate->outputPage()
#3 /home/lizardkg/venciclopedia.org/wiki/includes/MediaWiki.php(941): OutputPage->output(boolean)
#4 /home/lizardkg/venciclopedia.org/wiki/includes/MediaWiki.php(576): MediaWiki->main()
#5 /home/lizardkg/venciclopedia.org/wiki/index.php(50): MediaWiki->run()
#6 /home/lizardkg/venciclopedia.org/wiki/index.php(46): wfIndexMain()
#7 {main}

Exception caught inside exception handler: [ZcVMIKjQxmXUWP1zFpYmpwAAAAE] /index.php?title=Jorge_Aguilar Error: Call to undefined method PivotTemplate::getOutput()
Backtrace:
from /home/lizardkg/venciclopedia.org/wiki/skins/pivot/Pivot.skin.php(35)
#0 /home/lizardkg/venciclopedia.org/wiki/includes/skins/SkinTemplate.php(155): PivotTemplate->execute()
#1 /home/lizardkg/venciclopedia.org/wiki/includes/skins/SkinTemplate.php(181): SkinTemplate->generateHTML()
#2 /home/lizardkg/venciclopedia.org/wiki/includes/OutputPage.php(2899): SkinTemplate->outputPage()
#3 /home/lizardkg/venciclopedia.org/wiki/includes/exception/MWExceptionRenderer.php(184): OutputPage->output()
#4 /home/lizardkg/venciclopedia.org/wiki/includes/exception/MWExceptionRenderer.php(103): MWExceptionRenderer::reportHTML(Error)
#5 /home/lizardkg/venciclopedia.org/wiki/includes/exception/MWExceptionHandler.php(132): MWExceptionRenderer::output(Error, integer)
#6 /home/lizardkg/venciclopedia.org/wiki/includes/exception/MWExceptionHandler.php(249): MWExceptionHandler::report(Error)
#7 /home/lizardkg/venciclopedia.org/wiki/includes/MediaWiki.php(598): MWExceptionHandler::handleException(Error, string)
#8 /home/lizardkg/venciclopedia.org/wiki/index.php(50): MediaWiki->run()
#9 /home/lizardkg/venciclopedia.org/wiki/index.php(46): wfIndexMain()
#10 {main}