Topic on Extension talk:Lingo

Not showing tooltip for specific cases

10
Summary last edited by Elcapitan68 11:54, 21 February 2023 1 year ago

A patch created for and tested on MW 1.39. User successfuly applied the proposed changes on MW 1.38

Pspviwki (talkcontribs)
Elcapitan68 (talkcontribs)
Pspviwki (talkcontribs)

Correct vl (2) is not the term. vl is the term, 2 in brackets is numbering. There is a space between vl and the bracket. But the defect is that the tooltip does not appear when you hover over vl that is followed by the bracket. Examples under heading Examples of standard instrumentations or line "2 fl trans solo, vl (2), vla, b, cor (2)"

Elcapitan68 (talkcontribs)
Elcapitan68 (talkcontribs)
Pspviwki (talkcontribs)
Bawolff (talkcontribs)

It seems like it happens where it has a partial match where there is some prefix that would be a match, and there is some additional suffix that would be a match, but the actual text is in the middle, which confuses lingo.

In the particular case - "vl" matches and "vl solo" would also be a match. However, in the case of "vl (2)", lingo matches up to "vl " (vl followed by a space) but after the space, fails to match anything further. Instead of falling back to "vl" it gives up there. So that's why "vl" matches (newline and space are considered differnt) and "vl(2)" would match, but "vl (2)" does not.

Anyways, there is a patch for this issue at https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Lingo/+/886439

p.s. I noticed https://www.violinwiki.org/wiki/Terminology has text "This page is not part of main but because of Lingo it has to be in Main.". Just FYI you can change the name of the terminology page by editing the page MediaWiki:lingo-terminologypagename to have whatever name you want.

Pspviwki (talkcontribs)

Sorry guys, could not give you proper test result yet, implemented Lingo 3.1.2 (836982a) from distributor for 1.38.2, the patch is for 1.39 and production environment will not go to 1.39.

Bawolff (talkcontribs)

Fwiw, nothing in that patch is 1.39 specific. You could probably just make the same changes to an older version of Lingo

Pspviwki (talkcontribs)

Done. a. 836982a install kept, updated src/Tree.php with 886439. Results so far so good. b. updated MediaWiki:lingo-terminologypagename to a template, good as well (I had some trouble during initial tests, no problems now).