Topic on Extension talk:Favorites

MW 1.35.4, PHP 7.4.24

Howdy,

when clicking "+Favorite", a small message box appears "An error occurred when changing the favorites setting for ..."

By activating the debug options in LocalSettings, I find the following log entry in the Apache error log:

AH01071: Got error 'PHP message: PHP Deprecated:  Use of InternalParseBeforeSanitize hook (used in VariablesHooks::onInternalParseBeforeSanitize) was deprecated in MediaWiki 1.35. [Called from MediaWiki\\HookContainer\\HookContainer::run in [........]/mediawiki/includes/HookContainer/HookContainer.php at line 132] in [........]/mediawiki/includes/debug/MWDebug.php on line 430', referer: [...page name.....]

Anyone else having the same problem? What can I do to find out more ?

Disable Deprecated errors in production:

https://serverfault.com/questions/263167/disabling-php-deprecation-warnings-and-notices

This doesn't seem to be the error you're getting, however. If that doesn't fix it, hit F12 to open your browser's console and check the network tab, and try again. You may see a more meaningful error message inspecting the response from the server on the network tab

... not really. The network tab shows an answer of "200" on a post request, and the detailed view tells me:

{"error":{"code":"internal_api_error_Error","info":"[ad70de264e45ab8a9f92a964] Caught exception of type Error","errorclass":"Error"}}

so it seems the extension itself handles an exception. All well-known debug options in LocalSettings are set, the Mediawiki log file is empty.

In PHP, deprecation warnings are off:

error_reporting = E_ALL & ~E_DEPRECATED & ~E_STRICT

but this seemingly does not work as Apache reports the warnings as "AH01071 Got error".

Set $wgShowExceptionDetails to true in LocalSettings.php to get a more descriptive error message.

$wgShowExceptionDetails = true and I thought it had been so before ... after some try&error, I still can't find no stacktrace nowhere, neither in the Mediawiki log nor in the Apache logfile. But eventually the browser network viewer tab tells me a little bit more:

"internal_api_error_Error"

"[792bf7348e100b98b656ca9a] Exception caught: Call to undefined method ApiFavorite::dieUsageMsg()"

"Error at [.......]/extensions/Favorites/api/ApiFavorite.php(41)\n

#0 [.......]/includes/api/ApiMain.php(1593): ApiFavorite->execute()\n

#1 [.......]/includes/api/ApiMain.php(529): ApiMain->executeAction()\n

#2 [.......]/api/ApiMain.php(500): ApiMain->executeActionWithErrorHandling()\n

#3 [.......]/api.php(90): ApiMain->execute()\n

#4 [.......]/api.php(45): wfApiMain()\n

#5 {main}"

Obviously part of our installation is outdated, the extension or some of the core functions. Mediawiki = 1.35.4, PHP = 7.4.3, Favorites = 1.1.3 (downloaded few days ago via ExtensionDistributor). Do I have the wrong extension version?

ApiFavorites line 29-42:

               if ( $params['unfavorite'] ) {

                       $res['unfavorited'] = '';

                       $res['message'] = $this->msg( 'removedfavoritetext', $title->getPrefixedText() )->title( $title )->parseAsBlock();

                       $success = false;

                       //$success = UnfavoriteAction::doUnfavorite( $title, $user );

               } else {

                       $res['favorited'] = '';

                       $res['message'] = $this->msg( 'addedfavoritetext', $title->getPrefixedText() )->title( $title )->parseAsBlock();

                       $success = false;

                       //$success = FavAction::doFavorite( $title, $user );

               }

               if ( !$success ) {

                       $this->dieUsageMsg( 'hookaborted' );

               }

$success is always st to false!?

APIBase::dieUsageMsg was removed in MediaWiki 1.32:

Release_notes/1.32#Action_API_internal_changes_in_1.32

Looks like this extension is not compatible with MediaWiki 1.36 despite what the extension infobox says...

Sadly I see. Repairing the code is far beyond my skill. I hope someone someday will take the necessary steps.

Many thanks for your support.

i test the extension and i thought it was the problem due to the use of the Titlemovecomplete hook that was removed in mediawiki 1.37, so I left a warning on the extension page but I see that it is something else, if someone could make a patch in gerrit I would be grateful because the extension is still interesting

I'm having the same issue using Mediawiki 1.38.4-1, mariadb 10.9.3-3, PHP 8.1.12-2.

The extension now have a patch for fix that problems

@Rdrg109

@2003:C2:3F1C:100:A11D:7FB3:D263:8A51

you must fix the extension with the next patch: https://gerrit.wikimedia.org/r/969298

Patch is your answer? Really? What a joke.

The documentation page states the extension is stable. I can either download via Extension Distributor or I can use the git repository download. In either case I get an extension that does not work, problems are the same as described above. We have a test installation of 1.39 now, nothing has changed, problems are the same. as with 1.35.

I don't have the knowledge to apply a patch nor am I willing to learn that. You are distributing an extension that crashes, you are able to patch, so why won't you just correct that piece of software so that the extension distributor and the git repository are up do date.

No words could express what I'm feeling. Ground control to spaceship Mediawiki, please do your job then I'll do mine.

Jobs are normally paid. However, in the Open Source ecosystem, most work is unpaid and volunteer, so this is not anyone's job to do. You got what you paid for.

You're right. Everyone get what they paid for. Nothing is for free.