Topic on Skin talk:Cosmos/Flow

Fixed

Given the following menu items in the MediaWiki:Sidebar. When a bullet item is empty it is still drawn. No other skins behave this way, they all simply exclude those bullet items from the menus entirely. This would be nice to get fixed for cases where logic is used within the menu to present dynamically defined menu items. For example, here under Dynamic, if the user is a sysop then they get a link to PageForSysops but if they are not then the get a link to FAQforOthers. But the next link does not have the ELSE portion, so it will be empty output for non sysop users. When this last link is rendered in the menu it appears as an empty clickable link to nothing. If there are many logic based links there can be quite a lot of empty space which other skins simply skip over entirely. Thanks for any tips before I start digging into the code myself.

* Navigation

** randompage-url|randompage

*** helppage|help-mediawiki

**

**

* Dynamic

** {{#ifsysop:PageForSysops|SysOps or FAQ|FAQforOthers|FAQ}

** {{#ifsysop:PageForSysops|SysOps or FAQ}}

Thanks for bringing it up, I will also look into this soon. Does this happen when you set the menu in MediaWiki:Cosmos-navigation or just when in MediaWiki:Sidebar, and embeded into MediaWiki:Cosmos-navigation through {{int:sidebar}}?

Great question. I will test that out. I have thus far left MediaWiki:Cosmos-navigation as is and am using the main Sidebar because all skins (more or less) utilize that menu.

Yup, they appear to still render empty menu items if logic or non logic results in an empty ** or *** item.

Ok, thank you for verifying that, I will look into this tomorrow also and hopefully deploy a fix. Thanks again!

Hello, I'd like to apologise for the delay in fixing this. Some personal things came up. I will try and get it done as soon as possible.

No worries, whenever you get to it. If I had more time myself I might take a stab at a fix myself.

This should now be fixed