Topic on Extension talk:SphinxSearch

I upgraded mediawiki to 1.34 and SphinxSearch to the version that matches version 1.34. When I run a search I get this error:

[895083e3cfe4edcfab999700] /testwiki/index.php?search=Celia&title=Spezial%3ASuche&go=Seite ArgumentCountError from line 28 of /srv/www/htdocs/testwiki/extensions/SphinxSearch/SphinxMWSearchResult.php: Too few arguments to function SphinxMWSearchResult::getTextSnippet(), 0 passed in /srv/www/htdocs/testwiki/includes/widget/search/FullSearchResultWidget.php on line 65 and exactly 1 expected

When I took a look at SphinxMWSearchResult.php found that getTextSnippet is expecting the parameter terms

       public function getTextSnippet( $terms ) {

However I found this in the 1.34 release notes.

* SearchResult::getTextSnippet( $terms ) the $terms param is being deprecated

  and should no longer be passed. Search engine implemenations should be

  responsible for carrying relevant information needed for highlighting with

  their own SearchResultSet/SearchResult sub-classes.

Is the error caused by a bug or by a configuration issue?

This is a bug in the SphinxSearch extension code. I submitted a pull request here with the necessary changes: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/SphinxSearch/+/587360/

Thank you, Lavamind!

for 1.35 add the if

       public function getTextSnippet( $terms = [] ) {
               global $wgAdvancedSearchHighlighting, $wgSphinxSearchMWHighlighter, $wgSphinxSearch_index;
               if (empty($terms)) {
                       $terms=$this->mterms ;
               }

sorry, I didn't read all your comments:

the solution from Lavamind is the solution