Marking as resolved, fix in the patches described in this thread.
Hi, I've installed the Extension:DeletePagesForGood, but when I try to delete a page, it doesn't work. The error is
Warning: preg_split(): No ending delimiter ':' found in <SITE PATH>\extensions\DeletePagesForGood\ActionDeletePagePermanently.php on line 165
Exception encountered, of type "Error"
----
PHP 7.0.9
MediaWiki 1.27.1
Hi I reported it here https://phabricator.wikimedia.org/T146598
May be because there was a change in php7, since I tested this on php 5.
hi I did this test fix https://gerrit.wikimedia.org/r/#/c/312796/ would you be able to test it please?
If it works I can then merge it.
Now I'm getting the error
[238883a4ce388335357e7dab] 2016-09-25 22:58:22: Fatal exception of type "DBUnexpectedError"
Oh, iv'e updated https://gerrit.wikimedia.org/r/#/c/312796/ with a different fix, could you try that please.
Unless it may be using old db stuff which then I will need to see if that is broken.
Could you also set
$wgShowExceptionDetails = true;
and
$wgDevelopmentWarnings = true;
in localsettings.php, it may give us more info on what is causing the DBUnexpectedError error please?
[e0d818fd90271f519995febd] /site/index.php?title=DeletionTest&action=delete_page_permanently DBUnexpectedError from line 2668 of <site path> \includes\db\Database.php: MediaWiki::preOutputCommit: Flushing an explicit transaction, getting out of sync!
Backtrace:
#0 <site path> \includes\db\loadbalancer\LoadBalancer.php(1055): DatabaseBase->commit(string, string)
#1 <site path> \includes\db\loadbalancer\LBFactory.php(206): LoadBalancer->commitMasterChanges(string)
#2 <site path> \includes\db\loadbalancer\LBFactorySimple.php(154): LBFactory->{closure}(LoadBalancer, string, array)
#3 <site path> \includes\db\loadbalancer\LBFactory.php(208): LBFactorySimple->forEachLB(Closure, array)
#4 <site path> \includes\db\loadbalancer\LBFactory.php(250): LBFactory->forEachLBCallMethod(string, array)
#5 <site path> \includes\MediaWiki.php(560): LBFactory->commitMasterChanges(string, array)
#6 <site path> \includes\MediaWiki.php(539): MediaWiki::preOutputCommit(RequestContext)
#7 <site path> \includes\MediaWiki.php(750): MediaWiki->doPreOutputCommit()
#8 <site path> \includes\MediaWiki.php(519): MediaWiki->main()
#9 <site path> \index.php(43): MediaWiki->run()
#10 {main}
And I have an another question - is it possible to permanently delete a single edit from the history (e.g. a vandal one), because the only way to do this now is to hide it with the RevisionDelete thing; when I want to delete it from the db?
I'm not sure about the edit thing but the db that looks like changes in mediawiki core, I know someone who does the mw db I can ask him for help with this.
Yeah, it would be great; an extension like Delete Revision for Good ; maybe in the future.
Hi could you also test this https://gerrit.wikimedia.org/r/#/c/312797/ fix please?
[a9f6a78146dcbf0085a96a0c] /site/index.php?title=DeletionTest&action=delete_page_permanently DBUnexpectedError from line 2658 of <site path> \includes\db\Database.php: Got COMMIT while atomic sections ActionDeletePagePermanently::deletePermanently are still open
Backtrace:
#0 <site path> \includes\db\loadbalancer\LoadBalancer.php(1055): DatabaseBase->commit(string, string)
#1 <site path> \includes\db\loadbalancer\LBFactory.php(206): LoadBalancer->commitMasterChanges(string)
#2 <site path> \includes\db\loadbalancer\LBFactorySimple.php(154): LBFactory->{closure}(LoadBalancer, string, array)
#3 <site path> \includes\db\loadbalancer\LBFactory.php(208): LBFactorySimple->forEachLB(Closure, array)
#4 <site path> \includes\db\loadbalancer\LBFactory.php(250): LBFactory->forEachLBCallMethod(string, array)
#5 <site path> \includes\MediaWiki.php(560): LBFactory->commitMasterChanges(string, array)
#6 <site path> \includes\MediaWiki.php(539): MediaWiki::preOutputCommit(RequestContext)
#7 <site path> \includes\MediaWiki.php(750): MediaWiki->doPreOutputCommit()
#8 <site path> \includes\MediaWiki.php(519): MediaWiki->main()
#9 <site path> \index.php(43): MediaWiki->run()
#10 {main}
Ok I've updated https://gerrit.wikimedia.org/r/#/c/312797/ with a different fix could you try that please?
Oh, thanks for trying my fixes. I will get them merged tomarror :)
did it delete the page?
just wondering to make sure the fix did not have any unexpected changes that stopped it from deleting pages
OK thanks I'm merging the patches now. And will backport them to the REL1_27 branch :)