The following comments where put in inline comments by several editors, I've moved them here:
- Is each use of
fopen()
,fread()
, etc. checked for errors or problems?- does this mean that there is error handling?
- If you've created a new function, have you documented its parameters and what it returns?
- need to note where this should be documented
- Have you used the proper output functions?
echo
should almost never be used.- where do we find this info? needs link. not in coding conventions
- Have you use the proper termination functions?
exit
should almost never be used.- where do we find this info? needs link. not in coding conventions
- * Where appropriate, have you used the MediaWiki wrapper functions instead of their PHP equivalents?
- where do we find this info? needs link. not in coding conventions
-
wfIniGetBool()
instead ofini_get
to get boolean params- it doesn't seem that the various wf* functions are documented