Extension talk:WikiEditor/2017

→ pre LQT talk on this page

Diff styles not loaded? (MW 1.27.1, REL1_27 branch of WikiEditor)

The following discussion is closed. Please do not modify it. Subsequent comments should be made on the appropriate discussion page. No further edits should be made to this discussion.

---

I'm using WikiEditor with the "wikieditor-preview" option on. I just noticed that it seems like mediawiki.action.history.diff isn't loaded at all when I click the "Changes" tab - it shows a diff, with strikeouts for deletions, etc., but no colors (which come from the above module, apparently).

I see no errors on the console (or in the network resources tab), and it works just fine if I click the bottom diff button (which shows a diff view below the textarea), as well as in the regular changes view (action=history).

In jquery.wikiEditor.preview.js there's an API call to diff, which I can see actually happens; but the style module isn't loaded.

This might be happening since I upgraded to MW 1.27 (from MW 1.26), and I just haven't noticed so far...

Any ideas what the issue could be, or how I can further debug it? FFS ^Talk 11:56, 1 February 2017 (UTC)

Never mind, a few seconds after posting this I finally found Phab:T142845; it's a shame this wasn't backported to the REL1_27 branch of WikiEditor. I've now requested it would be.

As a workaround, you can set

$wgDefaultUserOptions['uselivepreview'] = true;

, because it loads module 'mediawiki.action.edit.preview', which depends on the needed 'mediawiki.action.history.diff'. FFS ^Talk 12:06, 1 February 2017 (UTC)

Please note that User:TheDJ indeed backported the fix to the REL1_27 branch. Thank you :-)

Users can pull the changes or redownload the extension from the extension distributor. FFS ^Talk 12:51, 4 February 2017 (UTC)

The discussion above is closed. Please do not modify it. No further edits should be made to this discussion.

Toolbar bold/italic buttons have "wrong" appearance

We have a fairly freshly installed LAN-based wiki (so I can't link to it from here) which runs on MW 1.27.1. The two first editor buttons (Bold and Italic) show as A A instead of the normal B I like on other EN-language wikis (no biggie, but confusing nonetheless). I assume this is caused by a configuration setting somewhere, but where and what? Metalbunny (talk) 10:15, 12 March 2017 (UTC)

2 secs later someone figured out that the bar gets confused when there are multiple languages set in localsettings. Removing everything but "en" makes it appear correctly. This really needs to be in the documentation. Metalbunny (talk) 10:19, 12 March 2017 (UTC)

"A" is the generic, since the "B for Bold" idea doesn't apply to most languages (it'd be "G for Gras" in French, "F for Fett" in German, etc.). Whatamidoing (WMF) (talk) 00:33, 14 March 2017 (UTC)

WikiEditor.php missing after upgrade

The following discussion is closed. Please do not modify it. Subsequent comments should be made on the appropriate discussion page. No further edits should be made to this discussion.

---

after using this to upgrade 10 minutes ago:

git pull

git submodule update # not sure if needed but I've done for a year

wiki stopped working due to missing WikiEditor.php file in the extenstion folder.

commenting the WikiEditor.php line in LocalSettings.php got around the error. both visual and source editors work per fast testing. RobFantini (talk) 02:31, 9 May 2017 (UTC)

You probably have to switch to the wfLoadExtension syntax in your LocalSettings.php. Almost all well maintained current versions of plugins have will now have finished their conversion from the require_once "$IP/extensions/WikiEditor/WikiEditor.php"; strategy to wfLoadExtension( 'WikiEditor' ); —TheDJ (Not WMF) (talk • contribs) 16:01, 9 May 2017 (UTC)

hello TheDJ - that fixed the situation. I'll read up on and apply the new method. Thank You. 173.76.181.125 (talk) 12:46, 10 May 2017 (UTC)

The discussion above is closed. Please do not modify it. No further edits should be made to this discussion.

Signature button

When I press on the signature button, I get a "<sig-text>" tag. Any idea how to remove/set it up ?

Thanks ! DSwissK (talk) 20:42, 12 June 2017 (UTC)

I think that creating MediaWiki:Sig-text (presumably with ~~~~ and/or whatever text you want to be pasted in when you click that button) would solve your problem. Whatamidoing (WMF) (talk) 18:27, 16 June 2017 (UTC)

Wow! Easy as 1 2 3. Thanks, you just saved my wiki ! ;) DSwissK (talk) 18:34, 16 June 2017 (UTC)

I'm glad that I could help.

It might not work for people who have set their user interface language to something other than the default. (It might; it might not. I don't know.) Whatamidoing (WMF) (talk) 20:38, 16 June 2017 (UTC)

The interface language of my wiki is French so I guess it does work.

And, if it can help someone else, I set "$1" on the page content. DSwissK (talk) 11:04, 17 June 2017 (UTC)

WikiEditor not appearing? Check mod_pagespeed

Spent a half-day troubleshooting why WikiEditor would not load after upgrading to 1.27. Read through every page of this discussion trying to figure it out.

I finally hit on mod_pagespeed as a culprit. We have mod_pagespeed enabled under apache. We've learned that while a powerful tool, mod_pagespeed causes all kinds of problems. Changes to Mediawiki:Common.css don't take effect, for example. Our solution?

Flush the cache.

We now have a bash script (got this solutions from somewhere else, probably StackOverflow) that we run now whenever we touch something that might be cached (css, js).

#!/bin/bash
touch `grep "^ *ModPagespeedFileCachePath" /etc/httpd/conf.d/pagespeed.conf | awk ' { print $2; } ' | sed 's/"//g'`/cache.flush

It pulls the location of the mod_pagespeed cache out of the httpd configuration, then touches the cache.flush file, which causes the cache to flush on next page request.

Just flushing the cache caused WikiEditor to magically appear.

Good luck, all! Lsilverman (talk) 17:01, 15 June 2017 (UTC)

Customizing the toolbar (loading ext.wikiEditor.toolbar?)

I am trying to customize my WikiEditor toolbar (Extension:WikiEditor/Toolbar customization), but I don't manage to add/remove buttons :-(

I'm not sure that I have done the following:

"The module "ext.wikiEditor.toolbar" needs to be loaded."

How can I do? How can I check if ext.wikiEditor.toolbar is properly loaded?

Any help would be highly appreciated.

Thanks

Livio LivioRobaldo (talk) 16:20, 5 July 2017 (UTC)

MW Rel 1.29.0 : bug report : Cancel button does not work properly

WikiEditor cancel button (upper right corner) redirects to uri /undefined. Here you are a screen shot.

Could it be fixed in the next release? Spas.Z.Spasov (talk) 14:07, 18 July 2017 (UTC)

I see this on my site too. I have temporarily disabled the Publish/Cancel buttons on the upper right. The buttons at the bottom seem to be working just fine. 139.165.107.44 (talk) 09:33, 24 August 2017 (UTC)

I am using MW 1.29.1, by the way. Still see the issue. 139.165.107.44 (talk) 12:11, 24 August 2017 (UTC)

Though it's just a temporary and convenient precaution (not a solution), I've disabled just the not-working Cancel button... leaving the still-working Publish button in place... by editing the jquery.wikiEditor.publish.js file in the modules directory to delete (or comment out) the following code:

context.fn.addButton( {
    captionMsg: 'wikieditor-publish-button-cancel',
    action: function () {
        window.location.href = $( '#mw-editform-cancel' ).attr( 'href' );
        return false;
    }
} );

NOTE: This is not a good solution for MW1.29 and MW1.29.1. A better solution is provided below. However, if the WikiEditor extension is not fixed to resolve this problem before the general release of MW1.30, then those with MW1.30 and onward may want to resort to this inadequate fix. Abhidevananda (talk) 03:42, 11 September 2017 (UTC)

Problem solved for MW1.29.0 and MW1.29.1

The issue and the workaround are detailed in the MW1.29 release notes. A solution to the problem is found there and also here.

In short, all that you need to do is add the following code in LocalSettings.php.

$wgOOUIEditPage = false;

NOTE: This workaround will only help with the MW1.29 releases. From MW1.30 onward, we are stuck with the red Cancel button (as seen below any edit box on this page) instead of the blue Cancel button from earlier releases (that this fix takes us back to). So the developers of WikiEditor will have to make some change in the extension code to accommodate that. Abhidevananda (talk) 12:36, 11 September 2017 (UTC)

Thanks a bunch, Abhidevananda and others. This worked for me. 139.165.107.44 (talk) 18:14, 20 September 2017 (UTC)

Image upload broken

The following discussion is closed. Please do not modify it. Subsequent comments should be made on the appropriate discussion page. No further edits should be made to this discussion.

---

When clicking on "Embedded file", the "insert file" window pops up. But when I click on "upload" there, the window closes and nothing happens. This problem occurs in my 1.29.0 version, in a separate 1.28.2 installation (on the same server), the upload works fine.

In the browser console, I get the following error (in the 1.28.2 version, I don't get errors):

:Uncaught Error: Windows must have a `name` static property defined.

load.php?debug=false&lang=en&modules=jquery.accessKeyLabel%2Casync%2CbyteLength%2CbyteLimit%2Ccheck…:537

at OoUiWindowManager.OO.ui.WindowManager.addWindows (load.php?debug=false&lang=en&modules=jquery.accessKeyLabel%2Casync%2CbyteLength%2CbyteLimit%2Ccheck…:537)

    at HTMLDivElement.wikieditor-toolbar-tool-file-upload (load.php?debug=false&lang=en&modules=ext.wikiEditor|ext.wikiEditor.core%2Cdialogs%2Cpreview%2Cpubli…:60)

    at HTMLButtonElement.props.click (load.php?debug=false&lang=en&modules=jquery.ui.button%2Ccore%2Cdialog%2Cdraggable%2Cmouse%2Cpositio…:24)

    at HTMLButtonElement.dispatch (load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=0ax79ee:65)

    at HTMLButtonElement.elemData.handle (load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=0ax79ee:60)

Is this a bug in the new version? Marccreal (talk) 14:13, 19 July 2017 (UTC)

Hi there, good spot.

This was bug T164999 which we fixed a few hours after the cut for MediaWiki 1.29 and didn't notice, sorry!

I've made https://gerrit.wikimedia.org/r/#/c/366262/ as a backport of the fix, and that should be released in MediaWiki 1.29.1. If it's urgent, you should be able to apply it locally.

Sorry for the issue. Jdforrester (WMF) (talk) 14:36, 19 July 2017 (UTC)

Thank you for the quick response! I applied the changes in "mediawiki.Upload.Dialog.js" and now the upload works again. Marccreal (talk) 09:29, 20 July 2017 (UTC)

The discussion above is closed. Please do not modify it. No further edits should be made to this discussion.

Disable on mobile skin?

My wiki uses media queries to alter the skin for mobile phones. Is there any way to stop this extension from running when the screen resolution is lower than a certain amount? I guess I could use CSS to hide the editor but it's not a great solution. 137.50.151.210 (talk) 20:55, 30 October 2017 (UTC)

Have you looked into Extension:MobileFrontend, which I believe has an editing system designed for smaller screens? Whatamidoing (WMF) (talk) 19:15, 3 November 2017 (UTC)