Extension:MobileFrontend/Deployments/2013-07-09
Stories
edit* https://mingle.corp.wikimedia.org/projects/mobile/cards/839 * Save from preview in editor
* https://mingle.corp.wikimedia.org/projects/mobile/cards/832 * In-article nav tweaks in beta
* https://mingle.corp.wikimedia.org/projects/mobile/cards/976 * QA - Automation - Must be logged in to use Uploads
* https://mingle.corp.wikimedia.org/projects/mobile/cards/977 * QA - Automation - Must be logged in to use Watchlist
Bugs
edit* https://bugzilla.wikimedia.org/show_bug.cgi?id=50761 * Nearby broken on desktop - Uncaught TypeError: Cannot set property 'ontouchstart' of undefined
* https://bugzilla.wikimedia.org/show_bug.cgi?id=43271 * #content_0 missing on small pages
* https://bugzilla.wikimedia.org/show_bug.cgi?id=50681 * Empty watchlist description: repeated sentence
* https://bugzilla.wikimedia.org/show_bug.cgi?id=46581 * Compilation failed: regular expression is too large in ApiQueryExtracts
* https://bugzilla.wikimedia.org/show_bug.cgi?id=50703 * MobileFrontend: User button tooltip is broken
* https://bugzilla.wikimedia.org/show_bug.cgi?id=50618 * Search placeholder is double escaped
* https://bugzilla.wikimedia.org/show_bug.cgi?id=50621 * References broken in beta when position fixed not supported
* https://bugzilla.wikimedia.org/show_bug.cgi?id=50410 * Clicking edit on page that doesn't exist broken
* https://bugzilla.wikimedia.org/show_bug.cgi?id=50397 * Uploads page anon user redirect
* https://bugzilla.wikimedia.org/show_bug.cgi?id=50571 * Template:PLURAL not working in 'mobile-frontend-diffview-editcount' message
* https://bugzilla.wikimedia.org/show_bug.cgi?id=50202 * Diffing between different content models throws a fatal error
* https://bugzilla.wikimedia.org/show_bug.cgi?id=50255 * Talk page shows a talk button
Uncategorized
edit* Localization updates * Fix jumping watchstar spinner * Drop iphone device stylesheet support * Remove -o-box-sizing * Remove kindle stylesheet * Bug alpha ensure heading is correct on nearby overlay * Allow editing on special cased main page * Remove superfluous GetMobileNotice call * Add missing / in filenames * Regression: fix a JS error on upload with a nag * Fixed partial search automation test * Tweaks to cleanup templates * Set padding o header to avoid collision with collapse control * Regression: Correctly use extend * Remove deleted message from Resources.php * Style all the inputs and textareas in the same way * Make editor license links open in separate tabs * Fix text being cut off at the bottom of inline buttons * Regression: Fix talk overlay button * Inform users why certain functions are not enabled
Git Log
editcommit cb550478efec892c7fbaee0ac73c9e02b7abb09e Author: jrobson <jrobson@wikimedia.org> Date: Fri Jul 5 15:35:26 2013 -0700
Inform users why certain functions are not enabled For editing and uploading when disabled Change-Id: Ia7bd862b8a11079692472c6e60406f5b02b62023
commit 1e37276f7225ed4248f4f6f369e0ed03175b08a5 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Mon Jul 8 16:57:01 2013 -0700
Fix talk overlay button Regression after redoing editor preview. Change-Id: I6e9087bd0cdcca3c28b553ef4f936c299a104e5d
commit f6043514b0186bf7a1c13bfedd59a9ea7c6adfeb Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Mon Jul 8 16:11:39 2013 -0700
Fix text being cut off at the bottom of inline buttons E.g. letter g, y, etc. Change-Id: I2614e583ae2c4177f5be70e7c1be6f7019a198d1
commit e8597a966519b9254ad95add28e9707f73d144eb Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Mon Jul 8 15:10:25 2013 -0700
Make editor license links open in separate tabs Change-Id: Ib2588d6e34b14e0d7ad950496296af44158d979a
commit 4f7ea845c770427a8acb61aa5e5f3f5c27c0fece Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Mon Jul 8 15:33:47 2013 -0700
Style all the inputs and textareas in the same way Rounded corners, same kind of border. Also, simplify search input's CSS a bit (and its clear button). Change-Id: I9775185114bffe45debaf167e1b80e15ef7f0f67
commit 17bb6bd3be38a72a46c50b9992e515d6e94c49ec Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Fri Jul 5 18:08:23 2013 -0700
Story 839: Save from preview in editor Remove PreviewOverlay and treat preview as the last stage of the EditorOverlay. Add summary to EditorApi. Change-Id: Icac5b5f1418528ef08acfb6b5047d7d24e0e924e
commit d2863cac4200066d4c136ccdc01259bff5bb973d Author: jrobson <jrobson@wikimedia.org> Date: Mon Jul 1 11:54:28 2013 -0700
Story 832: Show icons when not available / add new assets Change-Id: I9ceea67010590ff71e95a168d49dbad59aae85a0
commit fb80b9e7c33186ec6d424cc056237ab265a12350 Author: cmcmahon <cmcmahon@wikimedia.org> Date: Mon Jul 8 15:19:34 2013 -0700
name scenarios Change-Id: Ia6aa02c2f218471f3d5323b4b15aabed45e9a9ad
commit 6e67f8c29d7a29868fe954095a3aa48da4cc68e8 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Mon Jul 8 15:06:52 2013 -0700
Remove deleted messages from Resources.php Change-Id: Iebf6a00defad7c3411769f9d45ab7824e861afc8
commit bba103458b5a0108624787ef21196f21cb5a5be3 Author: Michelle Grover <jcmish1@gmail.com> Date: Mon Jul 8 00:26:22 2013 -0600
Automation tests for Mingle Stories#976 and #977 - Must be logged in to use Watchlist and Uploads Change-Id: Ibd6000067ccc9206ea48d2c0d1d860109753b7e0
commit d9096ab98c83f1d6ef560c13417f868db10fb79d Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Mon Jul 8 19:01:07 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: I4b2745d30b78a3f9b9139f1428e1ca8763e4ac48
commit 7d8ad0e5776a81c389210f1cbdc32a88e8d5a218 Author: jrobson <jrobson@wikimedia.org> Date: Mon Jul 8 11:31:02 2013 -0700
Regression: Correctly use extend extend alters the first argument. don't do this otherwise lead photo overlay and friends have the title 'Issues' Change-Id: I8361042573f3b42cf5f3c5088c8274dfbe68929f
commit 0a1901c62fca982f963e1476a428681047cdfd91 Author: Derk-Jan Hartman <hartman@videolan.org> Date: Sun Jul 7 00:31:48 2013 +0200
Set padding on header, to avoid collision with collapse control Change-Id: I75c37ded3cd9de80199e758483e184c15b620fb3
commit d7cfa2694df05e2e3f4e071e3ee25256aa8f1da2 Author: jrobson <jrobson@wikimedia.org> Date: Mon Jul 8 10:46:02 2013 -0700
Tweaks to cleanup templates According to beta labs it is possible to have cleanup template messages where a link is a first child Instead limit display block a tags to clickable lists remove redundant text decoration rule Change-Id: I8ce827d3f6172d8fdd67ed2637612828d003b35a
commit 4d727a4b18f87f4a62973cf831d57a7758d50655 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Sun Jul 7 19:43:18 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: Idd3baefb0aad14dc554b2a90ee9baaab3d6983dc
commit 53183ababc782694cb57a4aed75b947a120af68b Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Sat Jul 6 19:02:35 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: I1817488a0408582a758dae4a0bfdfb5d7fa0d6be
commit e99df0d727d24706cad4beb45a3c1b5423e8cb0d Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Fri Jul 5 18:39:37 2013 -0700
Fix jumping watchstar spinner Change-Id: Ibb6e022b5996f30007785e0c5e0b25e938ce53cd
commit cdbbe15ffddd5c0e9e4636ff05a6a1541afc3146 Author: jrobson <jrobson@wikimedia.org> Date: Fri Jul 5 18:02:02 2013 -0700
Fix nearby desktop view Bug: 50761 Change-Id: I7e522bbbf6a265b90df14131b2b29941355b7bfc
commit 448f8e4c4501bbc6254dcda4453cda2843aac76a Author: jrobson <jrobson@wikimedia.org> Date: Fri Jul 5 12:19:36 2013 -0700
Drop iphone device stylesheet support Search placeholder displays fine in iOS 6 Not clear which version it was specific too and unable to find phone < iOS 6 Change-Id: I9057c07bc35f02f31a7ae42f039c964ac93a7d85
commit 54d5b6c25a21fb664c223a9a9290151f418c41a3 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Fri Jul 5 14:53:18 2013 -0700
Remove -o-box-sizing from .box-sizing LESS mixin I doubt it even exists. MDN and caniuse.com don't mention it: https://developer.mozilla.org/docs/Web/CSS/box-sizing http://caniuse.com/css3-boxsizing Change-Id: I04fe604d380d8d7fbc7dc83fc80be4046989bc71
commit 4bf9be5dcca9c90650955d72c9610448f478cf39 Author: jrobson <jrobson@wikimedia.org> Date: Fri Jul 5 12:17:58 2013 -0700
Remove kindle stylesheet Also drop unused psp and wii css files Change-Id: I9dc1985c727039813f267f054a6809136839eceb
commit 4cb0035fbc291587b7a666a54b5d144e09610aeb Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Fri Jul 5 14:38:46 2013 -0700
Remove .border-radius LESS mixin and use border-radius border-radius is supported without vendor specific prefix in all modern browsers (https://developer.mozilla.org/docs/Web/CSS/border-radius). In many places, the mixin wasn't even used and only old properties with vendor prefixes were present. Change-Id: Ib27fb844279a24452b75929ce097ca7e7b80a2e7
commit ac55b3a811712014ce886e547b800a5a5b0c92a1 Author: jrobson <jrobson@wikimedia.org> Date: Fri Jul 5 12:16:29 2013 -0700
Remove blackberry stylesheet Testing on a version 4 (Blackberry 8900) shows this has no effect so is no longer needed Change-Id: Iee1da2b11e4177b8e7d451f68102081152882d7c
commit c811c3d77f9ba997a9deaf778f2b59f013cb4322 Author: jrobson <jrobson@wikimedia.org> Date: Fri Jul 5 12:06:20 2013 -0700
Device cleanup Remove empty device stylesheets Move nokia css rule into more generic rule in ui.css Change-Id: I1a5b2922998f7f4ed508814d17b97ee1f0da7958
commit a4b5a4f89b96ae531408a7f454a32137fc4c5dc2 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Fri Jul 5 17:19:03 2013 -0700
Show notifications (toasts) when overlay is open A regression caused toasts not to be shown when overlays were open (e.g. errors in editor overlay). Change-Id: I91d3972e7a2806e2b7a9e845e801fe8841ef0544
commit 91810b8336f6ebed81816d19d7baca090909f7b9 Author: jrobson <jrobson@wikimedia.org> Date: Fri Jul 5 17:12:08 2013 -0700
Only allow h2's to have an edit link styling on h3s etc is too strangr Change-Id: Icbbc1a29685350efdd988160821ba3c64114e679
commit badd66e954fec97b4efa7d51a073f3472f373184 Author: jrobson <jrobson@wikimedia.org> Date: Wed Jul 3 16:03:20 2013 -0700
Bug 43271: Always enable section collapsing html Decide in javascript whether to collapse.. Change-Id: I7f360f5b571895597ba06e483bea3a910e446f87
commit 6e918f38040700a46677e032184f0b02fbe583c0 Author: jrobson <jrobson@wikimedia.org> Date: Wed Jul 3 17:23:44 2013 -0700
Bug 50681: Don't duplicate the watchlist message when empty Bug: 50681 Change-Id: I38781ff7a96863c8bd2fa40d342ff65b2fcbd1e2
commit 5316b063455e040cd09f7f0bdf4a1b972e9c83f4 Author: jrobson <jrobson@wikimedia.org> Date: Fri Jul 5 11:25:10 2013 -0700
Hygiene: Cleanup the html for the cleanup templates oooh the irony We never got any style guidance for cleanup templates in the overlay itself so why not just list them with cleaner html and the icon and the text This also means we can kill the IE stylesheet which only exists for this purpose Change-Id: Ibb7420c53e2eded59e72fe6b55482abb5c6ad983
commit 652c636f9f07f01ef44335d9ff61d880125973a7 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Fri Jul 5 16:19:13 2013 -0700
Simplify .animation LESS mixin Make it more general and explicit (no arbitrary defaults). Now it is simply an alias for animation and -webkit-animation CSS properties. Change-Id: I8e7383a18ffb0bf3d6f56fd185e96c87524bbc20
commit 23901d7c699bdd966b226846510bd5fb8fe91976 Author: kaldari <kaldari@gmail.com> Date: Fri Jul 5 11:35:57 2013 -0700
Adding the page to the debugging output Bug: 46581 Change-Id: Ifab643922937dfe2f6882ed91c95f022ff000f55
commit dd85668328835bd7dd437c019a2e5abff144e9d8 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Fri Jul 5 15:23:13 2013 -0700
Remove -ms-linear-gradient from .vertical-gradient LESS mixin Comment claims that it's for IE 10, but it's not the case. IE 10 supports it without a vendor prefix, and IE < 10 doesn't support it at all (tested on Windows Phone 8). Possibly a non-final version of IE 10 needed it. https://developer.mozilla.org/docs/Web/CSS/linear-gradient http://caniuse.com/css-gradients Change-Id: I09add76ef5db3a990a8769ea8771bfa7931ebc29
commit 283c1dc7839e0502e0ff4328ab8a6a4cf0699983 Author: jrobson <jrobson@wikimedia.org> Date: Fri Jul 5 13:54:41 2013 -0700
Blindly remove simple, opera mini and opera mobile stylesheets Who knows what these undocumented rules are here for Nothing looks vital in these Change-Id: I9971836cbcea2f9a4c7b2857dcb881fa75386ed5
commit d692a1d5d283717200e2a3cec4d3ad7834a4589b Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Fri Jul 5 14:59:11 2013 -0700
Remove -moz-background-size from .background-size LESS mixin This is only used by Firefox 3.6. Firefox 4 supports it without the vendor prefix and Firefox <= 3.5 doesn't support it at all. Not worth it. https://developer.mozilla.org/docs/Web/CSS/background-size Change-Id: Ib1e876f75a7f331cae0300914eea1e69858915bb
commit 6d65df2a7e41d1562f54dbe1a96ec8c7168a0b4e Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Fri Jul 5 14:44:09 2013 -0700
Remove .boxshadow LESS mixin Not needed, box-shadow is supported without vendor prefixes in modern browsers. Old browsers probably shouldn't have shadows enabled anyway because it reduces performance on slower devices (especially scrolling). http://nerds.airbnb.com/box-shadows-are-expensive-to-paint http://daneden.me/2011/11/a-non-scientific-box-shadow-experiment/ Change-Id: I32801030958fcff9cd108e1ffa6f66f93671abe0
commit 9b7071f6862cb89d4de401125f3de9c09013fe75 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Fri Jul 5 21:39:03 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: Ife325a2c60f975fe5a5ec21bf82b9d9c4ff524ad
commit e214ef2e52995db8ee86f00e73ac03000a7da95d Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Fri Jul 5 14:11:27 2013 -0700
Fix delay property of notification transition (CSS) Delay is time and time can't be unitless in CSS: "Even if all units represent the same time for the value 0, the unit may not be omitted in that case as it isn't a <length>: 0 is invalid and does not represent 0s, 0ms." https://developer.mozilla.org/docs/Web/CSS/time This fixes the hiding transition in Firefox. Change-Id: I4f4001897691ef860ae321bae3913d8338fb897f
commit 026f20e2788eb537aabb5a0b53bfaba4e4b428a5 Author: jrobson <jrobson@wikimedia.org> Date: Fri Jul 5 13:35:11 2013 -0700
Prevent table of contents leaking into mobile No longer a table with latest corei See I4ecd0659d1f955a9b593d281a3fef0a81c218a52 Change-Id: I3dc78680fdd9eee6b7b6083619cfd5e37b74fea3
commit aa080c736f674b331c7569ed90f85c337a3d02bb Author: kaldari <kaldari@gmail.com> Date: Fri Jul 5 08:42:04 2013 -0700
Add missing i18n message for user notificaitons tooltip Bug: 50703 Change-Id: I71e45bd02a1052d36a186ce4bc31343c7dd24173
commit d9d5b3612bb52a417238f5a1208efd66d8562e74 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Thu Jul 4 20:08:42 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: I4279cf7b09b0de96d7169c084f873183e472da26
commit a9a04dae425f28b3d517a8d5754db60c04375f03 Author: kaldari <kaldari@gmail.com> Date: Wed Jul 3 18:05:25 2013 -0700
Fixing double escaping of searchbox placeholders. Bug: 50618 Change-Id: I3ca7496ad9613817f22c6b609d8773a5575c0d98
commit 1f1054af1ff6285febe8d27b5aa1eb863e1335d6 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Wed Jul 3 16:04:34 2013 -0700
Regression: fix background glitch in left nav Introduced in f532ca60e85530456aea9a9c5ddd4d363816a5f1 Without this, when the screen height was greater than left nav's height, grey background would extend below article's content. Change-Id: I3b28e823698de078dbf480f11b427976ccc1b446
commit f532ca60e85530456aea9a9c5ddd4d363816a5f1 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Fri Jun 28 18:30:01 2013 -0700
Fixes to animations (transitions) and notifications
Make those animations buttery smooth, glitchless and awesome.
* Put all notifications into a separate #notifications div (helps
sandbox those transformed elements better, seems to fix blurry text
for good).
* Create a more universal transition LESS mixin (accepts arbitrary
number of transitions just like transition CSS property).
* Animate only the required properties for notifications (not all
properties).
* Provide a reliable fallback for browsers that don't support
position: fixed (that works both with and without animations).
* Stop treating Firefox and MSIE 10 (Windows Phone 8) as if they didn't
support position: fixed.
Bug: 50621
Change-Id: I9aa603fae53c36184421c520e911f6e4b9ba5300
commit b60b5068049a214917d1f6519170442890b37417 Author: jrobson <jrobson@wikimedia.org> Date: Tue Jun 4 13:13:07 2013 -0700
Alpha: Allow commenting on talk topics * Add default styling for em tag * Create TalkSectionOverlay Change-Id: I731ff792d3a009503e530272f85c2dfedde03b74
commit 0d32012cbf1f58754ab54e6630991697afe6ae08 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Wed Jul 3 14:47:40 2013 -0700
Regression: re-enable new page creation Bug: 50410 Change-Id: Icd713ed7bf69ddf35203c6de0ff41a1d33e0b643
commit f579a91e0eba51f1bf06e2654893d25a0363902e Author: jrobson <jrobson@wikimedia.org> Date: Wed Jul 3 12:07:25 2013 -0700
Bug alpha: Ensure heading is correct on nearby overlay Currently wgTitle is binded to the first loaded page which is not wrong when lazy loading is happening Change-Id: If8888791ea735f6ca39095a7ad279b8eef83ea8f
commit 87b7fe60801a953de39a4507b708d51fb497caea Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Wed Jul 3 20:02:42 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: I7e12a5f34170d745863ba1a1277b672e11396a0b
commit 28426bdb1b20beb934e43618adc627ef6e3ff8e0 Author: jrobson <jrobson@wikimedia.org> Date: Tue Jul 2 16:49:52 2013 -0700
Allow editing on special cased main page Change-Id: Ia2f294905e8643a01adcd1126d480c0e87738bd4
commit f506cf3be99b854e4dd20cd2fd036d75c8d855e0 Author: kaldari <kaldari@gmail.com> Date: Tue Jul 2 15:58:18 2013 -0700
Fixing link to login page so that it returns users to upload page Bug: 50397 Change-Id: I4f7ee65bd483797ee4363f13b00ceba66dae40c2
commit 23d33d35874099c83d48383f46de8e3191c356b8 Author: dr0ptp4kt <abaso@wikimedia.org> Date: Tue Jul 2 12:51:55 2013 -0700
Remove superfluous GetMobileNotice call. * Currently, GetMobileNotice gets called twice instead of once. * This change will make it so that GetMobileNotice is only called once, from the WML context. It also removes some effectively dead code in a template view. * This change can be implemented independently. * Change 69336 may result in GetMobileNotice becoming the definitive banner generation hook (instead of the current split between MinervaPreRender and GetMobileNotice), although to be functional it will need to give the callee full control over the banners array at the last possible moment (similar to MinervaPreRender). Discussion is underway on change 69336. Change-Id: I151858a632fbd3456f38d2c28e512e959bd5a757
commit cd70da4373a4819b35130ce0d6c1aaed79111a28 Author: Max Semenik <maxsem.wiki@gmail.com> Date: Wed Jul 3 00:19:39 2013 +0400
Add missing / in filenames (Argh) Change-Id: I02c25b21d8a939f9267bb9b726f608f7afe38be1
commit 09c91ec38feb89c8a51011dfe3638440c2c734fe Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Tue Jul 2 19:22:29 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: Ie5c1b69aad6d8ba86c9c763d3279a9668530db99
commit 62765f16148fa93c76aaf44674ce352da148b4de Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Tue Jul 2 11:57:22 2013 -0700
Regression: fix a JS error on upload with a nag NagOverlay wasn't calling its parent constructor. Change-Id: I2bca90676185d690e4081b7648fd4dc8d00baa3f
commit f071054aae2e34b1d259728f7d3be88f737ecec2 Author: jrobson <jrobson@wikimedia.org> Date: Tue Jul 2 09:03:25 2013 -0700
Bug 50571: Make plural work for mobile-frontend-diffview-editcount Change-Id: Ib881581db0d53e9de4781835d554c588b777c2a5
commit 294e4fc5d2a7b115c6b37d070cb113fe2846a2e0 Author: jrobson <jrobson@wikimedia.org> Date: Mon Jul 1 12:09:08 2013 -0700
Bug 50212: Enable talk on project pages Change-Id: I884a21b1942216102c868bc7c190fc783a3c1991
commit be9c64eb267de6c222bc88ef83aa121f8a176ad8 Author: jrobson <jrobson@wikimedia.org> Date: Mon Jul 1 11:59:36 2013 -0700
Bug 50255: Talk page shows a talk button Correct bad css rule Replace it with a css rule which hides talk button on talk pages Change-Id: I89466dcc5cc6cea8bdcbb3d4e821b3da5fbbd184
commit 295e34858f4eb72ff4fe4c9aabe425f9bcdb61ca Author: Michelle Grover <jcmish1@gmail.com> Date: Sun Jun 30 17:21:18 2013 -0600
fixed partial search test Change-Id: I016243d05521002c0a30c222505c3288018cd153