Extension:MobileFrontend/Deployments/2013-06-05
Stories
edit* https://mingle.corp.wikimedia.org/projects/mobile/cards/435 * Left nav grouping
* https://mingle.corp.wikimedia.org/projects/mobile/cards/486 * Editing improvements
* https://mingle.corp.wikimedia.org/projects/mobile/cards/743 * Add monthly report graphs in limn
* https://mingle.corp.wikimedia.org/projects/mobile/cards/484 * Nearby to production
* https://mingle.corp.wikimedia.org/projects/mobile/cards/755 * Log editing attempts
* https://mingle.corp.wikimedia.org/projects/mobile/cards/485 * Promote talk pages to beta
* https://mingle.corp.wikimedia.org/projects/mobile/cards/580 * Contributory features in-article
* https://mingle.corp.wikimedia.org/projects/mobile/cards/495 * About link in left nav
* https://mingle.corp.wikimedia.org/projects/mobile/cards/768 * Editing preview
* https://mingle.corp.wikimedia.org/projects/mobile/cards/770 * Notifications (Echo) in beta
Bugs
edit* https://bugzilla.wikimedia.org/show_bug.cgi?id=47882 * mediawiki.page.ready should not be loaded on mobile * https://bugzilla.wikimedia.org/show_bug.cgi?id=48514 * History unavailable on main page (beta only)
* https://bugzilla.wikimedia.org/show_bug.cgi?id=48728 * Image thumbnails on Commons
Uncategorized
edit* Gem additions * Localization changes * Code Cleanup remove unused variables and template code * RenderPage Function added * Editor (beta): Refresh the page after an edit * Use mobile specific overlay * Move Zero banner to the Zero extension * Cleanup Margins on About and Disclaimer links * Cleanup Add Topic page for talk * Apply new watchstar and talk assets * DeviceType rewrite * Profiling
Git Log
editcommit 72feaa3cbbfc5a37a45a6ad203c9385cb42a0e0e Author: jrobson <jrobson@wikimedia.org> Date: Wed Jun 5 11:23:03 2013 -0700
Photo upload tweaks Insert photo in correct place in beta (#content_0) Show / hide rather than detach/recreate Change-Id: I5d2e6af157b386370f7a9cef7b620942b5b8b1ef
commit e93a6183341e21712adf26506024806aa52fa1a6 Author: jrobson <jrobson@wikimedia.org> Date: Wed Jun 5 11:14:19 2013 -0700
Use post for getting previews Otherwise we risk http error 414 Request URI too long Change-Id: I128a4301b733b2dcbd0e47cedd00ee0ef976ffe6
commit 2a8e0660bfb80bd5677203d244044e38535a7d18 Author: jrobson <jrobson@wikimedia.org> Date: Wed Jun 5 09:56:28 2013 -0700
Show upload cta to anonymous users who come from nearby Maryana says YES. Change-Id: Ic847726afb8914be057098ea0c5b9368a05a0356
commit 84875e9c2bb6d89a6a5fa5eb6899d2bdfe72e7f9 Author: Dr0ptp4kt <abaso@wikimedia.org> Date: Wed Jun 5 04:49:48 2013 +0000
Revert "Move zero banner to Zero extension" This reverts commit 39d0ae3e1bf7ccaddb15c562498174fc6b7f6df5 Change-Id: I20b9efd7e95becf918435724e662ab09f5254e16
commit 1219118219401f129657a2b561174d0c6a985ac7 Author: jrobson <jrobson@wikimedia.org> Date: Mon Jun 3 19:19:37 2013 -0700
Kill dead template code Lots of unused variables Change-Id: I24451cb8c9d05de94bede0536035bceea51fe822
commit bbe8189b37250ccb438cb57cf4e65d0b32c5dfc1
Author: jrobson <jrobson@wikimedia.org>
Date: Tue Jun 4 11:35:31 2013 -0700
Editor (beta): Refresh the page after an edit Don't force the user to unnecessarily refresh the page Change-Id: I167267dde2511c910acd1a1557250bdc8140c896
commit 308038ce234ef8f48cadf81aee6ee14c0858922d Author: jrobson <jrobson@wikimedia.org> Date: Wed May 29 12:45:43 2013 -0700
Add renderPage function Allow modules to re-render any given page Change-Id: I10b335a1d12396d810641e2cdde62064aca2f027
commit 7c3dca59496dfde3eca7fa903f9611a72ac40c0f Author: Zeljko Filipin <zeljko.filipin@gmail.com> Date: Tue Jun 4 15:55:50 2013 +0200
Explicitly require json gem to avoid warning message on Linux and Windows You are using an old or stdlib version of json gem Please upgrade to the recent version by adding this to your Gemfile: gem 'json', '~> 1.7.7' Change-Id: Id81403b947cba89224521ab4bb5ed56648156510
commit 12ea8867bd0224398e0f9ef2d4ae1ca6f4469a71 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Tue Jun 4 09:30:53 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: I10de1affb6ab635619799caf26e987b32f380594
commit 1219118219401f129657a2b561174d0c6a985ac7 Author: jrobson <jrobson@wikimedia.org> Date: Mon Jun 3 19:19:37 2013 -0700
Kill dead template code Lots of unused variables Change-Id: I24451cb8c9d05de94bede0536035bceea51fe822
commit d542db6e36c790c645e0fbcadb89996ec442537b Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Mon Jun 3 16:34:52 2013 -0700
Story 770: Add notifications (user) icon When Echo is loaded, the icon shows the number of unread notifications and is a link to Special:Notifications. When user is logged out, shows a CTA drawer. Also, removes the search button on special pages in alpha because there is no room for it anymore. Change-Id: I7fb40be2ff2fd6988dc2f64110a76a5867300ba2
commit a732e7f02628ae70862875633bcaa63624d0ec86 Author: jrobson <jrobson@wikimedia.org> Date: Mon Jun 3 17:23:45 2013 -0700
use M.require('Overlay')
If1b52a918d3cb457a4d30bd68c2343c0ffc26461 should have
been rebased before code review. Fixing mistake
Change-Id: I02ba39c30868c8e76ab09391203240f50026f09b
commit 49f3a1a22ae65acbaf2832c4ed446520333e27fe Author: jrobson <jrobson@wikimedia.org> Date: Mon Jun 3 17:11:56 2013 -0700
Code cleanup: Separate Overlay, Drawer and CtaDrawer from mf-navigation.js Change-Id: If1b52a918d3cb457a4d30bd68c2343c0ffc26461
commit 50a67c537aa92f8f56110f3a5e6cc31dc76ef48a Author: jrobson <jrobson@wikimedia.org> Date: Mon Jun 3 16:53:35 2013 -0700
Code hygiene: Use more generic nicer variable name for headings Change-Id: I6d706f51e8be2e5a738136163ac73cb27d683c5d
commit 39d0ae3e1bf7ccaddb15c562498174fc6b7f6df5 Author: jrobson <jrobson@wikimedia.org> Date: Thu May 23 10:42:42 2013 -0700
Move zero banner to Zero extension Make use of onMinervaPreRender hook (depends on https://gerrit.wikimedia.org/r/64608) Change-Id: I3f3d59f7c248fe6d4098f417bea75d2319d1031e
commit f840124611c0da9fb0a5b4aba1e9173221283beb Author: jrobson <jrobson@wikimedia.org> Date: Thu May 30 12:16:59 2013 -0700
Story 768: Add previews to editor * Add a preview button in between previous and next buttons * Add a close button on the preview screen in same position to make it easy to escape * In preview window load a preview of article using Section view (now exposed via define ) * Fix the overlay header to be aligned with the back arrow * Adds edit-preview event, make use in toggle and cleanup templates module to add this to preview Change-Id: I1f4bee08cf24c2ce2657d46b650b3e1a0532d408
commit 276714f07f0f1733041e57f9207d556faf8d0105 Author: jrobson <jrobson@wikimedia.org> Date: Fri May 31 17:05:58 2013 -0700
Only show add topic button if logged in Change-Id: Iae2259070171ae1cdb81b04a1d59e94a194316f7
commit f3f1a1e959fbbd63f629d1172d80604de50c5fa5 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Mon Jun 3 18:51:32 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: I50f5dd7efcc6ce7a3d19c3b6f8085316389e6931
commit 9cadfa557b8473797c82bb54bc57698bdcdbe23c Author: jrobson <jrobson@wikimedia.org> Date: Tue May 28 18:04:11 2013 -0700
Story 485: Promote talk overlay to beta Change-Id: I6f34055713031e26f9e15c92102739d90d2f41ab
commit ec01df39f0a5c80e864a502d956fdb9e545c4384 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Mon Jun 3 11:51:18 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: I1a95061200ab3e401e432417387174601eda64ee
commit 3204cbb3f1449786145ab2cb19cd0ed0cda158e1 Author: Zeljko Filipin <zeljko.filipin@gmail.com> Date: Mon Jun 3 11:02:59 2013 +0200
Updated Ruby gems Change-Id: I72f1d9f1af95804246d7e865414df053750946b8
commit 2fa1668ae90bfe8e08d3a1129f0d835fcb36d7dd Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Fri May 31 17:14:00 2013 -0700
Tweak margins for About and Disclaimer links Change-Id: I2762187e11971ea46ba82ce87d3ba5de743f750c
commit e9f676547e90c558af4f39a3121a65fe6193fb9e Author: jrobson <jrobson@wikimedia.org> Date: Tue May 28 18:16:23 2013 -0700
Tweak add topic page for talk Add legal text to save screen Bring template more in line with EditorOverlay Change-Id: I78ee47894a2d1170c9b99c44548b5806cfc5dc9d
commit defe373458858615a27b30f7dacca3b7d3a46490 Author: jrobson <jrobson@wikimedia.org> Date: Fri May 31 11:59:48 2013 -0700
Apply new watch star and talk assets Tweak css on talk page so label aligns with center (accounts for bubble tail) Change-Id: Ia486cb163722fe594c55451a3b1d37bf9635f602
commit d8d8efb78c4e7919964164b12a7c2e76751aee98 Author: jrobson <jrobson@wikimedia.org> Date: Fri May 24 15:41:06 2013 -0700
Story 580: New page menu Add a new menu under the page title * Adds support for (un)watching articles for non javascript users * Adds talk page link for non javascript users * Update photo uploader to work from the menu rather than a full screen CTA * New watch star icon * Ensure backwards compatibility with old HTML (checked against HTML in I9b4f41c96a9b497634b71c889bf7628c44ad5be7) Change-Id: Ib9a11206dcf4242b7eff0177a410f27288258a9e
commit 19da9fdae4ffe9b720677514b249f5e25913c073 Author: jrobson <jrobson@wikimedia.org> Date: Tue May 28 12:37:30 2013 -0700
Story 755: Add event logging to editing Dependency: https://gerrit.wikimedia.org/r/65843/ Change-Id: Id63c15675d33c0c7cf1072ea48060856ac1ebeeb
commit c0d5ab86fbfc385db5f78ee4c19c13e1cb72085f Author: jrobson <jrobson@wikimedia.org> Date: Wed May 29 09:55:36 2013 -0700
Story 495: Add about and disclaimer links to menu Change-Id: I19b4a9984a376e6c610bad12bcc6727178b8f617
commit ae8dc5d279d2e520faf42a1562bcccd2e343c606 Author: Max Semenik <maxsem.wiki@gmail.com> Date: Thu May 2 04:13:40 2013 +0400
Device type rewrite
* Use regexes only if necessary, in most cases strpos() is enough.
* Since there's now no difference between 'capable' and 'html'
(jQuery support is irrelevant), merge them into 'generic'
* Order the checks approximately in the order of popularity
per http://stats.wikimedia.org/wikimedia/squids/SquidReportClients.htm
to reduce the average number of regexes run per request.
* Simplify non-default iPhone browser handling.
* Reduce the worst-case number of regexes.
* Remove unused firefox.css, neither Fennec is supported nor it's a proper
way to fix such problems.
* Make 'ie' cover all IE Mobile versions.
* Kill 'wap2', 'wii' and 'psp'.
* Removed a couple of mobileness detection rules covered by MIDP.
* Sort rules.
Change-Id: I79401aee6ec91eeda19a2ff5f010c4406f568c9b
commit b2ad082b40bd0e59bae280d22a48f0c18210195b Author: jrobson <jrobson@wikimedia.org> Date: Thu May 30 15:31:49 2013 -0700
Remove code that does nothing Seems to have sneaked in during I7588246bbdaa90be221d7cb531373eb5b1233bf2 Change-Id: Idfcd6d3ceead528d73aeaae0b190cc3c4256adc1
commit 81093f6e4ef78092e2a93b7cc5ef6dbd0e860df2 Author: jrobson <jrobson@wikimedia.org> Date: Mon May 13 15:34:45 2013 -0700
Bug 47882: Redefine default modules for Minerva Skin Make use of getDefaultModules Depends on: https://gerrit.wikimedia.org/r/63584 Bug: 47882 * Kill enableModules and attachResources functions * Move watch star and search code to desktop skin Change-Id: Id79b90204badd82ebd02a9351ca0434c2cb47a21
commit 97a405278da12d06eb2e010621c76b608776b160 Author: jrobson <jrobson@wikimedia.org> Date: Thu May 30 13:40:02 2013 -0700
Bug 48514: Always redirect to desktop when hitting history url Add FIXME suggestion - this should probably in future redirect to the latest diff Change-Id: Ibc3328b30433348d012d5089cb1eda144a7d04bb
commit 3d21942af813394a5f97c31e7d3c424d3ff90fa8 Author: Max Semenik <maxsem.wiki@gmail.com> Date: Thu May 30 02:29:31 2013 +0400
Profiling Change-Id: If7e448dad916eca5fbe985d398f6072d3714e7f6
commit 1742d074556f48102cf96befae9b2c635d0a234f Author: jrobson <jrobson@wikimedia.org> Date: Wed May 29 10:50:50 2013 -0700
Code cleanup: Remove unused homepage-loaded event. Change-Id: I217c4065d33752267c6f576f05fdf55f41c730f4
commit 4dfffa31728d09cf51332abd9a6a02a31093ec15 Author: jrobson <jrobson@wikimedia.org> Date: Wed May 29 10:28:56 2013 -0700
Cleanup: Kill unused getPageArrayFromApiResponse Not used in code base so killing. Using $.map instead Change-Id: I6ba5ce48d1debc7956a4f6253a568ee1059aa4a9
commit eb7d0e4c2b7d0660b606f34825dff1e533366bae Author: Zeljko Filipin <zeljko.filipin@gmail.com> Date: Wed May 29 16:44:19 2013 +0200
Upgraded Ruby to 2.0.0-p195 Change-Id: If447db2ac6e2066e136725d66a49b4d8b61d32e9
commit e57f6d28f658ee497a1b53ab807cafe98ff41146 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Wed May 29 08:39:51 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: Ie6a85dbd77b050378277839bc6ce22b9bc865c9b
commit dc80c98adce6d8c98475413d87e038e9b2cb0b85 Author: jrobson <jrobson@wikimedia.org> Date: Tue May 28 19:08:19 2013 -0700
Bug 48728: Scale thumbnails on Commons Change-Id: I330e277ae1034fe9cd018abfc84f72f6966cf91d
commit 4aa2d0466f9196a1e6b46e879f18a725679006d7 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Tue May 28 13:23:59 2013 -0700
Change edit link message 'edit' results in 'Edit this page' on testwiki and enwiki. Change-Id: I08e7e02e7ddc1afbe160b3b63d63998fd28887fc
commit 5f451e2a347d8057fb1672aaf1e15533ebbd6186 Author: Siebrand Mazeland <s.mazeland@xs4all.nl> Date: Sat May 25 10:24:40 2013 +0200
Fix spelling of JavaScript Change-Id: Ie487e3408802f76e383eec1a8e9b841cd86e0ecf
commit 18b602a9b2f4ae57bcbf80576c6bf05547c5d2e5 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Tue May 28 06:45:42 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: I17279d621201c2f3d75211df9e6ead63622df5b6