Extension:MobileFrontend/Deployments/2013-02-26

High Level Changes

Stories

* https://mingle.corp.wikimedia.org/projects/mobile/cards/405
* Add messaging to login/signup

* https://mingle.corp.wikimedia.org/projects/mobile/cards/397
* Add upload categories

Bugs

* https://bugzilla.wikimedia.org/show_bug.cgi?id=43271
* #content_0 missing on small pages

* https://bugzilla.wikimedia.org/show_bug.cgi?id=45217
* JS templates broken in Firefox (desktop)

Uncategorized

* Localization changes
* Ruby Gems update
* Move lead photo upload to stable 
* Fix Margins for thumbnail - watchlist (alpha) 
* Detect disabled file upload controls on FireFox OS 1.0
* Show upload button again if user cancels upload
* Fix left and right margin uploads dashboard 
* Use autoless to compile LESS files 
* Don't show or log an error when user cancels photo upload 
* Add photo upload support for Firefox 
* Send all photo upload request parameters in FormData

Git Log

commit c7341184a02429f1ef225290f01dbc1b1f1aab83 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Fri Feb 22 17:34:23 2013 -0800

   Move lead photo upload to stable
   
   Fixed version, including mediawiki.util as a RL dependency.
   
   Change-Id: I4074cad79282713d99ff20257d8182278ad2644d

commit df95fa63e092de935a861515e1cfa42f2299ca4e Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Mon Feb 25 16:28:31 2013 -0800

   Fix margin for thumbnails in watchlist (alpha)
   
   Change-Id: If926a6c1c4ac11625b3c0c075b27befbee8b17c4

commit a008c62e51497fb9b96835a22baefa1434ca8d56 Author: Zeljko Filipin <zeljko.filipin@gmail.com> Date: Mon Feb 25 15:48:03 2013 -0800

   Updated Ruby version to 2.0
   
   Change-Id: Ib5502e68fc83859b8b0bb90389196e2f5bf6bb91

commit 85240940efce91932ffc549624501ed9583c896e Author: Brion Vibber <brion@pobox.com> Date: Mon Feb 25 14:07:52 2013 -0800

   Detect disabled file upload controls on Firefox OS 1.0
   
   Firefox for Android and desktop support file uploads, but the actual
   <input type="file"> is not yet supported on Firefox OS. As of 1.0, it
   silently drops the "type='file'" and turns file upload controls into
   text fields.
   
   This is kind of annoying, as otherwise all the infrastructure is there,
   such as FormData and FileReader.
   
   Patch adds detection for the Firefox OS case which will gracefully
   start picking up the functioning controls when they get added in future
   versions.
   
   Change-Id: I9bfefa39b56c97b65116c9e1f18409cb10d06867

commit 0e2a125e6be7d98da3b9f9f2ce0490f03e79b56d Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Thu Feb 21 13:48:33 2013 -0800

   Show upload button again if user cancels upload
   
   Previously, after cancelling an upload the page would remain with no
   button (unless refreshed).
   
   Change-Id: Ia3361d4ccea8c582a2d2d59864b79381b95b5d69

commit 9d5165aeb0d9c98cf14ea2cd368a81ae9764329c Author: MaxSem <maxsem.wiki@gmail.com> Date: Mon Feb 25 22:29:24 2013 +0000

   Revert "Move lead photo upload to stable"
   
   This reverts commit 5a41bb2f2234a6d0505c684c36ceb7641ac3de13
   
   Change-Id: Ib5cedb58e1663dd91da13b0581b62bc2efc12f8a

commit 7706f1bab5d453f17ec0a915f26ac0f5882aba96 Author: Zeljko Filipin <zeljko.filipin@gmail.com> Date: Mon Feb 25 13:46:35 2013 -0800

   Updated Ruby gems
   
   Change-Id: I8442ed7d84371f42f6a3e42f513835c8a3c07ec2

commit 0ca5415e6d8de24bd7e38abae077a48b30d00dfb Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Fri Feb 22 15:38:59 2013 -0800

   Fix left and right margin in uploads dashboard
   
   Regression introduced in Ibcb8b571204ab9e1651957ff0e286d67f743b95d
   
   Change-Id: I3e401390d0f19bea68cb4572de6ef4eda8cc3749

commit 98f0d69624fd75190569390e2c572e0d6bb0c8ea Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Mon Feb 25 21:06:17 2013 +0000

   Localisation updates from http://translatewiki.net.
   
   Change-Id: Ibad2e5467c9cd05cad5a8cf2641070cb4aae331a

commit f15459001a91b919d53b91dae477bfee87e66a97 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Sun Feb 24 20:40:09 2013 +0000

   Localisation updates from http://translatewiki.net.
   
   Change-Id: I2267fc97a22be15b0e7c78628714c55dce4f8b5d

commit dc4a4138b8de337331d62901f0d2cb934734e251 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Sat Feb 23 20:38:01 2013 +0000

   Localisation updates from http://translatewiki.net.
   
   Change-Id: I3ff47d370d4a2cff09fd2a4f900a900f8ba5c6fc

commit 5a41bb2f2234a6d0505c684c36ceb7641ac3de13 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Fri Feb 22 17:34:23 2013 -0800

   Move lead photo upload to stable
   
   Change-Id: I2c160255445ae61c4370c55132c78a2d0106e20e

commit 0a56cc29c6707c1c301cd298fae1046139733609 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Fri Feb 22 16:43:44 2013 -0800

   (bug 43271) Workaround for missing #content_0
   
   This enables the photo upload button in short articles.
   
   Change-Id: Iaa3df3754c2e55973b4402991bd0a69689260169

commit 24bc3f5e25da169ecd989c49d37dea328dae2afa Author: awjrichards <arichards@wikimedia.org> Date: Fri Feb 22 14:04:06 2013 -0700

   (mingle #405) Add dynamic head msg on login/acct create form
   
   * Preserves 'sign up', 'sign in' overlay headers on login/acct create form
   * Sets head msg to 'You must be logged in to watch pages.' when login/acct
   create form reached from tapping watchlist start
   * Sets head msg to 'You must be logged in to see your uploads.' when
   login/acct create form reached from Special:DonateImage
   
   Change-Id: I07b1be58ae227d973d4981819da6a8dd38e77142

commit b1a2d35f10786e2a5d0f2c8be24340ef462f12ad Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Fri Feb 22 20:12:12 2013 +0000

   Localisation updates from http://translatewiki.net.
   
   Change-Id: Ieed36fa445ff91a341ad9a99753c35801181764e

commit b0f0808082ca25ab0fe732bf6ea0d7b4791b8a4b Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Thu Feb 14 13:00:01 2013 -0800

   Use autoless to compile LESS files
   
   autoless is a .less file watcher I put together some time ago and
   improved recently. This changeset will not change anything for people
   who don't deal with .less files.
   
   For those who do:
   * make less is _much_ faster (and it still runs before every commit when
     .less files change)
   * there's no need for modifying Makefile when a new .less file is added
     to the project
   * you can run make lesswatch and it will keep monitoring .less files for
     changes and generate appropriate .css files if needed (it tracks
     dependencies, so if you change e.g. mf-mixins.less, everything that
     depends on it will get recompiled)
   
   It also adds make installhooks to install all the necessary git hooks
   (the new hooks pause lesswatch while doing git rebase so that git
   doesn't get confused by .css files being changed during a rebase).
   
   package.json file is used to make sure that appropriate Node.js modules
   are installed in MobileFrontend's directory, not parent directories.
   
   The small change in watchlist.css is a result of less not being run
   correctly in https://gerrit.wikimedia.org/r/#/c/48861/
   
   Change-Id: I0f095ec206901ea9bad45903953c66d2611311d9

commit 2254b19e7fce4333b362aa12c3aba8c7a1be2110 Author: awjrichards <arichards@wikimedia.org> Date: Fri Feb 15 15:28:02 2013 -0700

   (mingle 397) Append configurable string to photo upload description
   
   * Adds config var wgMFPhotoUploadAppendToDesc, the value of which will
   be appended to a photo description during upload.
   
   Change-Id: I7df9dce791693ed1fa79b9b2066116430f34cb92

commit b92b91a15d53b82191bd2a0a68124026b769b84b Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Thu Feb 21 13:39:47 2013 -0800

   Don't show or log an error when user cancels photo upload
   
   This is a regression after introducing event logging.
   
   Change-Id: I75b75e4d3c884ca76140a9bf55ebb59e679bb45c

commit 64dc97c43135a6fd7de2f8bbaa36ad349861d911 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Thu Feb 21 13:30:03 2013 -0800

   Add photo upload support for Firefox
   
   And possibly any other browser that supports FormData and FileReader.
   
   Change-Id: Id54befc5c5aab662d9a1b9eaf170b5f9c4a75a77

commit 16489ea9bce88d076bc45dc80258867b5e18f2ac Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Thu Feb 21 12:39:24 2013 -0800

   Send all upload request parameters inside FormData
   
   There is no reason for concatenating some of them as a querystring.
   
   Change-Id: Ifacbaa89f80a25a9cd7fada96fe7e9ee7da1d05b

commit 8e11ac916f57542d3958c8548817da9d9a88e34d Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Thu Feb 21 10:55:47 2013 -0800

   (bug 45217) Fix dependencies support in MFResourceLoaderModule
   
   Add support for 'dependencies' key in MFResourceLoaderModule. Also
   always depend on 'mobile.startup' (which contains code responsible for
   compiling templates).
   
   Change-Id: I148c6db90bf837f9813194a7835fa3edb9aa0247

commit 34349619c5fc0561f5ee7a54725209da9ba328e8 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Thu Feb 21 20:18:51 2013 +0000

   Localisation updates from http://translatewiki.net.
   
   Change-Id: I04e5370f312e4416e4b14531b5f611efc6b0dc39

commit 50fd324c0bc01e99f7c8195257b6638c4486f028 Author: Max Semenik <maxsem.wiki@gmail.com> Date: Thu Feb 21 23:41:13 2013 +0400

   Specify test group explicitly
   
   Change-Id: I53b963070dc0df0a9b3dc1bd385cee5c4cc7ca99

commit e5adba6e2494da27f61e45897317e791a0f759fb Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Wed Feb 20 15:52:34 2013 -0800

   Fix photo upload button not working after error
   
   When an error occurred when adding a lead photo to an article, the photo
   upload button no longer worked and the user was be unable to
   retry.
   
   This was caused by jQuery's .remove() unbinding all DOM events, .detach()
   should be used instead.
   
   Change-Id: Iba136eeb77ec4eea0b01eb0ded52e813471b50d2

commit 6d5d0dc1c2e02027a69e7351b0d8a1e7a02823eb Author: Max Semenik <maxsem.wiki@gmail.com> Date: Mon Feb 11 21:12:49 2013 +0400

   Display thumbnails in watchlist using PHP
   
   Easier and saves an API request, improving performance
   Use thumbnail size of 150 to ensure the image doesn't look pixelated
   Promote watchlist from alpha to beta
   
   Change-Id: I348705da83a9071c23bcb36593c0b3dde3e0a311

commit b9873f25219537bd3ff0fbfa94e580940f5eb317 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Fri Feb 15 11:25:01 2013 -0800

   Fix margins in uploads dashboard
   
   This reduces the margin and font-size for the number of uploads message
   (consulted with Munaf).
   
   Also, adds margin at the bottom of the page (after last image's
   description) and prevents the upload message from jumping from one place
   to another when JS is loaded.
   
   Change-Id: Ibcb8b571204ab9e1651957ff0e286d67f743b95d